test({react,preact}-query/usePrefetchQuery): use the '.then()' convention consistently#11091
Open
Antoliny0919 wants to merge 1 commit into
Open
test({react,preact}-query/usePrefetchQuery): use the '.then()' convention consistently#11091Antoliny0919 wants to merge 1 commit into
Antoliny0919 wants to merge 1 commit into
Conversation
…tion consistently
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated React and Preact ChangesPrefetch error test updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Two
queryFn.mockImplementationOnceoverrides inusePrefetchQuery.test.tsxare still written withasync/await, while the base implementation of the very samequeryFnalready uses.then().#10399/#10400converted themockImplementationof the sharedgenerateQueryFnhelper in these files, so these look like leftovers from that pass , they appear to be the lastmockImplementationOnce(async ...)in the repo.The rejection happens strictly after
sleep(10)resolves, so the timing is unchanged.Would it make sense to switch them to match the convention 🤔
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit