Skip to content

chore: enforce pnpm 11#332

Merged
KevinVandy merged 2 commits into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11
May 21, 2026
Merged

chore: enforce pnpm 11#332
KevinVandy merged 2 commits into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11

Conversation

@Sheraff
Copy link
Copy Markdown
Contributor

@Sheraff Sheraff commented May 21, 2026

Adds engines.pnpm >=11.0.0 to TanStack/store.

Scenario Result
pnpm@11+ install Allowed
pnpm@11+ run ... Allowed
pnpm@9 install Blocked by engines.pnpm
pnpm@9 run ... Blocked by engines.pnpm
pnpm@10 install with default pnpm version management Usually hands off to packageManager and runs as the declared pnpm version
pnpm@10 run ... with default pnpm version management Usually hands off to packageManager and runs as the declared pnpm version
pnpm@10 install with version handoff disabled Blocked by engines.pnpm
pnpm@10 run ... with version handoff disabled Blocked by engines.pnpm
pnpm@9/10 list Not blocked
pnpm@9/10 exec ... Not blocked
Field What It Does
packageManager Helps tools/newer pnpm select or hand off to the declared pnpm version
engines.pnpm: ">=11.0.0" Fails important project workflows when an older pnpm is actually executing them
engines.pnpm Does not intercept every pnpm subcommand

Summary by CodeRabbit

  • Chores
    • Updated the project to require pnpm version 11.0.0 or higher as the package manager.

Review Change Stack

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 21, 2026

View your CI Pipeline Execution ↗ for commit f0ed2b6


☁️ Nx Cloud last updated this comment at 2026-05-21 21:12:45 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 387a543a-d432-4300-b86d-4fb9a9931e09

📥 Commits

Reviewing files that changed from the base of the PR and between 2319b86 and ccc49f8.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

The root package.json now includes an engines block specifying that pnpm version 11.0.0 or higher is required to work with this project. This enforces a minimum package manager version constraint across the codebase.

Changes

Package Manager Version Constraint

Layer / File(s) Summary
Enforce pnpm version requirement
package.json
An engines section is added specifying pnpm >= 11.0.0 to enforce the minimum package manager version required for this project.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • TanStack/store#325: Also modifies package.json to update pnpm version specification (packageManager field to pnpm@11.1.0), complementing this PR's engines constraint.

Suggested reviewers

  • crutchcorn
  • KevinVandy

Poem

🐰 A tiny tweak, but oh so sweet,
Pnpm version now concrete,
Engines field declares the way,
Consistency rules the day! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@KevinVandy KevinVandy merged commit 86251e5 into TanStack:main May 21, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants