Skip to content

fix(solid): use native batch for reactivity adapter#6396

Merged
KevinVandy merged 1 commit into
betafrom
fix/solid-use-native-batch
Jul 9, 2026
Merged

fix(solid): use native batch for reactivity adapter#6396
KevinVandy merged 1 commit into
betafrom
fix/solid-use-native-batch

Conversation

@riccardoperra

@riccardoperra riccardoperra commented Jul 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal table reactivity support for better compatibility with Solid’s batching behavior.
    • No user-facing features, settings, or API changes were introduced.

@nx-cloud

nx-cloud Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 9b5b93b

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 5m 23s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-09 18:35:47 UTC

@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1a8691a9-2373-4d8d-ac48-1e791b63c5db

📥 Commits

Reviewing files that changed from the base of the PR and between 9db621f and 9b5b93b.

📒 Files selected for processing (1)
  • packages/solid-table/src/reactivity.ts
📝 Walkthrough

Walkthrough

The change updates the solid-js import statement in reactivity.ts to add batch to the list of imported utilities, alongside the existing createMemo, createSignal, observable, runWithOwner, and untrack imports. No other code was modified.

Changes

Import Update

Layer / File(s) Summary
Add batch import
packages/solid-table/src/reactivity.ts		 Added `batch` to the existing solid-js import list without modifying any other logic.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to use Solid's native batch in the reactivity adapter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/solid-use-native-batch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 9, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6396

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6396

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6396

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6396

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6396

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6396

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6396

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6396

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6396

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6396

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6396

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6396

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6396

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6396

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6396

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6396

commit: 9b5b93b

@KevinVandy KevinVandy merged commit 4fe5c7d into beta Jul 9, 2026
9 checks passed
@KevinVandy KevinVandy deleted the fix/solid-use-native-batch branch July 9, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees

@KevinVandy KevinVandy

@riccardoperra riccardoperra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@riccardoperra @KevinVandy