Skip to content

fix(styles/shop): remove '@theme inline' to silence lightningcss warning #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukvvon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(styles/shop): remove '@theme inline' to silence lightningcss warning #1036

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cdbe6e
fix(styles/shop): remove '@theme inline' to silence lightningcss warning
sukvvon Jul 7, 2026
2ed1a5f
Merge branch 'main' into fix/shop-css-theme-warning
sukvvon Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions src/styles/shop.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,22 @@
/*
* Shop theme — scoped to /shop pages via `.shop-scope`.
*
* Only three things live here:
* 1. CSS variable declarations for the light/dark token swap
* 2. A `@theme inline` block that exposes those vars to Tailwind so you can
* write `bg-shop-panel`, `text-shop-muted`, `font-shop-display`, etc.
* 3. Keyframes used by the live-stock indicator and CTA button.
* This file is injected as a plain <link> stylesheet (imported with `?url`),
* so it never passes through the Tailwind pipeline. The `bg-shop-panel`,
* `text-shop-muted`, `font-shop-display` utilities are generated from the
* matching `@theme inline` block in `app.css`; here we only declare the raw
* CSS variables those tokens resolve to, plus the light/dark swap and the
* keyframes used by the live-stock indicator and CTA button.
*
* Everything else is Tailwind utilities on components — no bespoke class
* selectors, no global leakage.
*/

@import url('https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap');

@coderabbitai coderabbitai Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use the configured import notation.

Stylelint expects the bare string form here, so this line will keep failing lint until the url(...) wrapper is removed.

Proposed fix 
-@import url('https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap');
+@import 'https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@import url('https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap');
`@import` 'https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap';
🧰 Tools
🪛 Stylelint (17.14.0)

[error] 15-15: Expected "url('https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap')" to be "'https://fonts.googleapis.com/css2?family=DM+Sans:ital,opsz,wght@0,9..40,100..900;1,9..40,100..900&family=DM+Mono:ital,wght@0,300;0,400;0,500;1,300;1,400;1,500&display=swap'" (import-notation)

(import-notation)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/styles/shop.css` at line 15, The stylesheet import in the top-level font
declaration is using the wrapped URL form, which conflicts with the configured
import notation. Update the existing `@import` in shop.css to use the bare string
form expected by Stylelint, keeping the same Google Fonts URL and leaving the
rest of the font setup unchanged.

Source: Linters/SAST tools


@theme inline {
--color-shop-bg: var(--shop-bg);
--color-shop-bg-2: var(--shop-bg-2);
--color-shop-panel: var(--shop-panel);
--color-shop-panel-2: var(--shop-panel-2);
--color-shop-surface: var(--shop-surface);
--color-shop-surface-hover: var(--shop-surface-hover);
--color-shop-line: var(--shop-line);
--color-shop-line-2: var(--shop-line-2);
--color-shop-text: var(--shop-text);
--color-shop-text-2: var(--shop-text-2);
--color-shop-muted: var(--shop-muted);
--color-shop-accent: var(--shop-accent);
--color-shop-accent-ink: var(--shop-accent-ink);
:root {
--color-shop-green: #22c993;
--color-shop-orange: #ff7a3a;

--font-shop-display: 'DM Sans', ui-sans-serif, system-ui, sans-serif;
--font-shop-mono: 'DM Mono', ui-monospace, SFMono-Regular, Menlo, monospace;
}

/* Light mode (default) */
Expand Down
Loading