Skip to content

Clarify that T_eff,crit differs from T_* in Sander et al. 2023 Eq. 1 (defined at Rosseland optical depth τ=20)#1458

Open
julia-haynes wants to merge 1 commit intoTeamCOMPAS:devfrom
julia-haynes:patch-1
Open

Clarify that T_eff,crit differs from T_* in Sander et al. 2023 Eq. 1 (defined at Rosseland optical depth τ=20)#1458
julia-haynes wants to merge 1 commit intoTeamCOMPAS:devfrom
julia-haynes:patch-1

Conversation

@julia-haynes
Copy link
Copy Markdown

This updates the comment to clarify that the effective temperature used in the correction corresponds to the critical/sonic-point temperature (T_eff,crit), which differs from T_* as defined in Sander et al. 2023 Eq. 1 at a Rosseland continuum optical depth of τ = 20.

… defined at a Rosseland continuum optical depth of 20.
@ilyamandel
Copy link
Copy Markdown
Collaborator

Thank you for that. There are some typos in the revised text (e.g., * in the middle of a line, "temperature" repeated one time too many). But my real question is about the last comment:

"Using T_eff as a proxy for T_eff,crit introduces a small approximation."

Do you have any information supporting this? It would be great to know how much of a difference it actually makes, i.e., how different the two temperatures are.

@jeffriley jeffriley added documentation Improvements or additions to documentation severity_minor This bug is not very severe urgency_low This issue is not urgent labels Mar 15, 2026
@jeffriley jeffriley requested a review from ilyamandel March 15, 2026 22:28
@ilyamandel
Copy link
Copy Markdown
Collaborator

@julia-haynes -- gentle ping on my question above.

@ilyamandel
Copy link
Copy Markdown
Collaborator

We'll aim to add some comments on this into the revised paper version; not sure if the code is a right place for this discussion. If there's no more feedback from @julia-haynes , I may close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation severity_minor This bug is not very severe urgency_low This issue is not urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants