Skip to content

Fix #531: Allow empty graphs in check_well_formed#537

Open
ECZ-Quantum-Labs wants to merge 15 commits into
TeamGraphix:masterfrom
ECZ-Quantum-Labs:fix-empty-graph-531
Open

Fix #531: Allow empty graphs in check_well_formed#537
ECZ-Quantum-Labs wants to merge 15 commits into
TeamGraphix:masterfrom
ECZ-Quantum-Labs:fix-empty-graph-531

Conversation

@ECZ-Quantum-Labs

Copy link
Copy Markdown

Before submitting, please check the following:

  • Make sure you have tests for the new code and that test passes (run nox)
  • If applicable, add a line to the [unreleased] part of CHANGELOG.md, following keep-a-changelog.
  • Format added code by ruff
    • See CONTRIBUTING.md for more details
  • Make sure the checks (github actions) pass.

Then, please fill in below:

Context (if applicable): Fixes issue #531 where empty graphs were incorrectly rejected by check_well_formed()

Description of the change: - Added early return for empty graphs in _check_flow_general_properties

Related issue:

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.84%. Comparing base (af1c16d) to head (a953392).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
graphix/flow/core.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   88.85%   88.84%   -0.01%     
==========================================
  Files          49       49              
  Lines        7135     7139       +4     
==========================================
+ Hits         6340     6343       +3     
- Misses        795      796       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matulni

matulni commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Hi @ECZ-Quantum-Labs, thanks for your contribution!
Our policy is that CI should pass before engaging in a PR review. Don't hesitate to ask if you have any questions.

@thierry-martinez

Copy link
Copy Markdown
Collaborator

The CI broke because of a new Matplotlib release. It was fixed in #541, which has now been merged. Could you merge the current master into your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants