Skip to content

Fix version fetcher for 26.1, bump version to 3.0.5#87

Open
Lumine1909 wants to merge 3 commits intoTest-Account666:masterfrom
Lumine1909:fix/26.1
Open

Fix version fetcher for 26.1, bump version to 3.0.5#87
Lumine1909 wants to merge 3 commits intoTest-Account666:masterfrom
Lumine1909:fix/26.1

Conversation

@Lumine1909
Copy link
Copy Markdown

@Lumine1909 Lumine1909 commented Apr 9, 2026

Resolves #86

@emmanuelvlad
Copy link
Copy Markdown

emmanuelvlad commented Apr 9, 2026

I tried your branch but I still get issues on paper 26.1:

[ModernPluginLoadingStrategy] Could not load plugin 'plugin-1.0.jar' in folder 'plugins'
java.lang.IllegalStateException: Provider SpigotPluginProvider{path=plugins/plugin-1.0.jar, description=org.bukkit.plugin.PluginDescriptionFile@3a48ea53, jarFile=plugin-1.0.jar@1bb4c39f, status=null, dependencyContext=null} attempted to add duplicate plugin identifier plugin v1.0 THIS WILL CREATE BUGS!!!
	at io.papermc.paper.plugin.storage.ServerPluginProviderStorage$1.applyContext(ServerPluginProviderStorage.java:28) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.entrypoint.strategy.modern.ModernPluginLoadingStrategy.loadProviders(ModernPluginLoadingStrategy.java:113) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:47) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.enter(SingularRuntimePluginProviderStorage.java:57) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.manager.RuntimePluginEntrypointHandler.enter(RuntimePluginEntrypointHandler.java:40) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.loadPlugin(PaperPluginInstanceManager.java:130) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[?:?]
	at java.base/java.lang.reflect.Method.invoke(Method.java:565) ~[?:?]
	at PlugManX-3.0.5.jar//core.com.rylinaux.plugman.util.reflection.MethodAccessor.invoke(MethodAccessor.java:56) ~[?:?]
	at PlugManX-3.0.5.jar//paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.loadPluginWithPaper(PaperPluginManager.java:189) ~[?:?]
	at PlugManX-3.0.5.jar//paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.load(PaperPluginManager.java:156) ~[?:?]
	at PlugManX-3.0.5.jar//core.com.rylinaux.plugman.auto.AbstractAutoFeatureManager.lambda$setupAutoReload$1(AbstractAutoFeatureManager.java:179) ~[?:?]
	at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1791) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1644) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:449) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.processPacketsAndTick(MinecraftServer.java:1702) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1372) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]

@Test-Account666
Copy link
Copy Markdown
Owner

I tried your branch but I still get issues on paper 26.1:

[ModernPluginLoadingStrategy] Could not load plugin 'plugin-1.0.jar' in folder 'plugins'
java.lang.IllegalStateException: Provider SpigotPluginProvider{path=plugins/plugin-1.0.jar, description=org.bukkit.plugin.PluginDescriptionFile@3a48ea53, jarFile=plugin-1.0.jar@1bb4c39f, status=null, dependencyContext=null} attempted to add duplicate plugin identifier plugin v1.0 THIS WILL CREATE BUGS!!!
	at io.papermc.paper.plugin.storage.ServerPluginProviderStorage$1.applyContext(ServerPluginProviderStorage.java:28) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.entrypoint.strategy.modern.ModernPluginLoadingStrategy.loadProviders(ModernPluginLoadingStrategy.java:113) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:47) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.manager.SingularRuntimePluginProviderStorage.enter(SingularRuntimePluginProviderStorage.java:57) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.manager.RuntimePluginEntrypointHandler.enter(RuntimePluginEntrypointHandler.java:40) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.loadPlugin(PaperPluginInstanceManager.java:130) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[?:?]
	at java.base/java.lang.reflect.Method.invoke(Method.java:565) ~[?:?]
	at PlugManX-3.0.5.jar//core.com.rylinaux.plugman.util.reflection.MethodAccessor.invoke(MethodAccessor.java:56) ~[?:?]
	at PlugManX-3.0.5.jar//paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.loadPluginWithPaper(PaperPluginManager.java:189) ~[?:?]
	at PlugManX-3.0.5.jar//paper.com.rylinaux.plugman.pluginmanager.PaperPluginManager.load(PaperPluginManager.java:156) ~[?:?]
	at PlugManX-3.0.5.jar//core.com.rylinaux.plugman.auto.AbstractAutoFeatureManager.lambda$setupAutoReload$1(AbstractAutoFeatureManager.java:179) ~[?:?]
	at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1791) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1644) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:449) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.processPacketsAndTick(MinecraftServer.java:1702) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1372) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[aspaper-26.1.1.jar:26.1.1-DEV-b0c5c9d]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]

Ignoring the unknown fork "aspaper", please try a reload through commands aswell.

The automatic reload feature is known to be somewhat unstable

@Lumine1909
Copy link
Copy Markdown
Author

Sorry, I made some stupid mistakes.
Now it should work, but the logger for auto-reload feature can't resolve minecraft color char, should I address it in this pr?
image

@Test-Account666
Copy link
Copy Markdown
Owner

Sorry, I made some stupid mistakes.
Now it should work, but the logger for auto-reload feature can't resolve minecraft color char, should I address it in this pr?
image

I'd prefer a new PR since this is a separate issue

@Lumine1909
Copy link
Copy Markdown
Author

Sorry, I made some stupid mistakes.
Now it should work, but the logger for auto-reload feature can't resolve minecraft color char, should I address it in this pr?
image

I'd prefer a new PR since this is a separate issue

Okay, I'll start once this pr is merged

@LoneDev6
Copy link
Copy Markdown

Thanks for the fix, will this be released this week?

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Comment thread plugman-paper/pom.xml
</execution>
</executions>
</plugin>
<!-- <plugin>-->
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if this is necessary, I can't build it with this plugin.

@Lumine1909
Copy link
Copy Markdown
Author

Thanks for the fix, will this be released this week?

You can check this one : )

@Test-Account666
Copy link
Copy Markdown
Owner

Sorry it's taking so long...

Btw, why did you remove the license maven plugin in this PR?

@Test-Account666
Copy link
Copy Markdown
Owner

Ah, didn't see the comment (Am on a phone right now)

What exactly is the error you're receiving while building with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor support for 26.1

4 participants