Cleaned up code - some adjustments to selected files

The following adjustments were made:
- Files should end with a newline (PHP:S113)
- Control structures should use curly braces (PHP:S121)
- Mergeable "if" statements should be combined (PHP:S1066)
- Lines should not end with trailing whitespaces (PHP:S1131)
- Use empty() to check whether the array is empty or not (PHP:S1155)
- Unused function parameters should be removed (PHP:S1172)
- Unused local variables should be removed (PHP:S1481)
- PHP keywords and constants "true", "false", "null" should be lower
case (PHP:S1781)
- Unused assignments should be removed (PHP:S1854)
- "require_once" and "include_once" should be used instead of "require"
and "include" (PHP:S2003)
- "&&" and "||" should be used (PHP:S2010)

Author: DanProgs

lib/ajax/getreqspeclog.php

@@ -1,10 +1,10 @@
 <?php
-/** 
+/**
  * 	TestLink Open Source Project - http://testlink.sourceforge.net/
- * 
+ *
  * 	@filesource	getreqspeclog.php
  * 	@author 	Francisco Mancardi
- * 
+ *
  *	@internal Revisions:
  */
 require_once '../../config.inc.php';
@@ -31,4 +31,4 @@
     	$info = lang_get("empty_log_message");
     }
 }
-echo $info;
+echo $info;

lib/ajax/gettprojectnodes.php

@@ -179,6 +179,8 @@ function display_children($dbHandler,$root_node,$parent,$filter_node,$tcprefix,$
 
 /**
  *
+ * @param string $idList
+ * @param array $tcIDs
  */
 function getAllTCasesID($idList,&$tcIDs) {
 

lib/attachments/attachmentdownload.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * TestLink Open Source Project - http://testlink.sourceforge.net/ 
- * This script is distributed under the GNU General Public License 2 or later. 
+ * TestLink Open Source Project - http://testlink.sourceforge.net/
+ * This script is distributed under the GNU General Public License 2 or later.
  *
  * Downloads the attachment by a given id
  *
@@ -13,7 +13,7 @@
 require_once '../functions/common.php';
 require_once '../functions/attachments.inc.php';
 
-// This way can be called without _SESSION, 
+// This way can be called without _SESSION,
 // this is useful for reports
 // testlinkInitPage($db,false,true);
 // But it seems is creating this CVE https://nvd.nist.gov/vuln/detail/CVE-2022-35195
@@ -30,7 +30,7 @@
   if ($attachInfo) {
     switch ($args->opmode) {
       case 'API':
-        // want to check if apikey provided is right 
+        // want to check if apikey provided is right
         // for attachment context
         // - test project api key:
         //   is needed to get attachments for:
@@ -40,7 +40,7 @@
         //   is needed to get attacments for:
         //   test case executions
         //   test specifications  ( access to parent data - OK!)
-        //   
+        //
         // What kind of attachments I've got ?
         $doIt = false;
         $attContext = $attachInfo['fk_table'];
@@ -56,19 +56,16 @@
                      "WHERE id = " . intval($attachInfo['fk_id']);
 
               $rs = $db->get_recordset($sql);
-              if (!is_null($rs)) {
-                if($rs['0']['testplan_id'] == $item['id']) {
-                  // GOOD !
+              if (!is_null($rs) && $rs['0']['testplan_id'] == $item['id']) {
                   $doIt = true;
-                }  
-              }       
-            }  
+              }
+            }
           break;
         }
       break;
 
       case 'GUI':
-      default:   
+      default:
         $doIt = true;
       break;
     }
@@ -77,17 +74,16 @@
     if ($doIt) {
       $content = '';
       $getContent = true;
-      if( $args->opmode !== 'API' && $args->skipCheck !== 0 
-          && $args->skipCheck !== false) {
+      if( $args->opmode !== 'API' && $args->skipCheck !== 0 && $args->skipCheck !== false) {
         if( $args->skipCheck != hash('sha256',$attachInfo['file_name']) ) {
           $getContent = false;
-        }  
-      }  
+        }
+      }
 
       if ($getContent) {
         $content = $fileRepo->getAttachmentContent($args->id,
                                                    $attachInfo);
-      }  
+      }
 
       if ($content != "") {
 
@@ -100,8 +96,7 @@
 
         $what2do = "Content-Disposition: inline;";
         // is SVG?
-        if (strripos($content, "<!DOCTYPE svg") !== FALSE
-            || strripos($content, "<svg") !== FALSE) {
+        if (strripos($content, "<!DOCTYPE svg") !== false || strripos($content, "<svg") !== false) {
           if (!XSS_StringScriptSafe($content)) {
             $what2do = "Content-Disposition: attachment;";
           }
@@ -110,20 +105,19 @@
         @ob_end_clean();
         header('Pragma: public');
         header("Cache-Control: ");
-        if (!(isset($_SERVER["HTTPS"]) && $_SERVER["HTTPS"] == "on" && preg_match("/MSIE/",$_SERVER["HTTP_USER_AGENT"]))) { 
+        if (!(isset($_SERVER["HTTPS"]) && $_SERVER["HTTPS"] == "on" && preg_match("/MSIE/",$_SERVER["HTTP_USER_AGENT"]))) {
           header('Pragma: no-cache');
         }
         header('Content-Type: '. $attachInfo['file_type']);
         header('Content-Length: '.$attachInfo['file_size']);
 
-        header( $what2do . 
-                " filename=\"{$attachInfo['file_name']}\"");
+        header( $what2do . " filename=\"{$attachInfo['file_name']}\"");
         header("Content-Description: Download Data");
 
         echo $content;
         exit();
-      }      
-    }  
+      }
+    }
   }
 }
 
@@ -138,7 +132,7 @@ function init_args(&$dbHandler)
 {
   // id (attachments.id) of the attachment to be downloaded
   $iParams = array('id' => array(tlInputParameter::INT_N),
-                   'apikey' => array(tlInputParameter::STRING_N,64),  
+                   'apikey' => array(tlInputParameter::STRING_N,64),
                    'skipCheck' => array(tlInputParameter::STRING_N,1,64));
 
   $args = new stdClass();
@@ -149,7 +143,7 @@ function init_args(&$dbHandler)
   if( is_null($args->skipCheck) || $args->skipCheck === 0 )
   {
     $args->skipCheck = false;
-  }  
+  }
 
   // var_dump($args->skipCheck);die();
   // using apikey lenght to understand apikey type
@@ -161,7 +155,7 @@ function init_args(&$dbHandler)
   {
     $args->opmode = 'API';
     $args->skipCheck = true;
-  } 
+  }
   return $args;
 }
 
@@ -173,4 +167,4 @@ function init_args(&$dbHandler)
 function checkRights(&$db,&$user)
 {
   return config_get("attachments")->enabled;
-}
+}