Agent creation form UI polish: template grid, capability card, reasoning relocation - #2202
Merged
Merged
Conversation
…ty card, switch shape - Template picker: card title/description clamp to 2/4 lines with ellipsis; grid switches from auto-fit(240px)+center to a fixed 2-equal-column layout, left-aligned, so a lone last-row card doesn't stretch. - Capability card: drop the border-color transition and outer border (replaced by a surface-container fill), widen the toggle-to-content gap 12->16px, tighten vertical padding to 8px, add an on-surface/8% hover layer on top of the fill. Also drops the now-redundant per-child border-radius on .header/.subForm — .card's own overflow:hidden already clips them, and the duplication was producing a stray rectangular seam on hover. Selected-state label now changes color only, not font-weight. - Switch: replace the oversized --radius-2xl token with --radius-full (the actual pill/fully-rounded token) on the track and handle — the only shared Switch component, so this covers every toggle in the app. - FullPageModal: reserve the scrollbar gutter (scrollbar-gutter: stable) so centered modal content stops shifting left when a scrollbar appears — shared by every full-page modal, including the agent form. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… tab label This branch was cut from swift before the tab's i18n key (added in an earlier fix, then relabeled Tools->Capabilities on a sibling branch) existed there, so the raw key rendered again. Same fix, same "Capabilities"/ "Capacités" value as the sibling relabel branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…c CapabilityCard Relocates the REASON-01 reasoning offer from the agent form's General section into the Capabilities tab (renamed from Tools), reusing the exact same card component as template-provided capabilities instead of a reasoning-specific one. CapabilityCard is generalized to a plain name/description/checked/onToggle + optional `subForm` slot; a real capability passes CapabilityConfigForm (now exported separately) as that slot, reasoning passes a SwitchRow for its nested default-on toggle. One card component for the whole tab. Also makes the card's header fully clickable, edge to edge: the header is now the <label> itself (wrapping the Switch as a descendant, same pattern as SwitchRow) instead of a plain <div> whose padding sat outside a smaller inner label's box and swallowed clicks near the card's border. Amends MODEL-REASONING-ENABLEMENT-RFC.md (§17, Amendment C) and COMPONENT-UX.md to record the relocation — a frontend-only reversal of §15's tab-placement argument; reasoning is still not a capability underneath (no ConfigModel/TurnOptionsModel/middleware, single build_for_chat enforcement point). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switchatom now uses--radius-fullinstead of the oversized--radius-2xltoken — fixes every toggle in the app.surface-containerfill + on-surface/8% hover layer), widens the toggle-to-content gap, tightens vertical padding, selected-state label now changes color only (not weight). The whole header (padding included) is now the click target — was a<div>whose padding sat outside a smaller inner<label>, swallowing clicks near the card's edges.CapabilityCardis generalized into one reusable component (name/description/checked/onToggle+ asubFormslot) used for both real capabilities and the reasoning toggle — no reasoning-specific card component. Still not a real capability underneath (noConfigModel/TurnOptionsModel/middleware) — seeMODEL-REASONING-ENABLEMENT-RFC.md§17 (Amendment C) andCOMPONENT-UX.md, both amended in this branch.rework.teams.formAgent.sections.toolsi18n key (both landing on the same final value) — expect a possible trivial conflict depending on merge order.Test plan
make code-qualitymake test🤖 Generated with Claude Code