Draft
Conversation
dieselxxx
added
platform: FireHub Core
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public function testCall ():void { | ||
|
|
||
| $this->container->bind( | ||
| Str::class, fn(Container $container):object => new Str('test') |
Check warning
Code scanning / PHPMD
Unused Code Rules: UnusedFormalParameter Warning test
Closed
1 task
2 tasks
1 task
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-pre-alpha #91 +/- ##
========================================================
- Coverage 67.91% 57.06% -10.86%
- Complexity 3027 3813 +786
========================================================
Files 144 190 +46
Lines 5143 6451 +1308
========================================================
+ Hits 3493 3681 +188
- Misses 1650 2770 +1120
... and 15 files with indirect coverage changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Please provide a link to the ticket related to this change.
Example: fixes # (issue).
Description
Please include a summary of the change.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Type of change