Skip to content

IYWU: include necessary header for constant_fold()#10612

Open
hzeller wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260608-iwyu-constant-fold
Open

IYWU: include necessary header for constant_fold()#10612
hzeller wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260608-iwyu-constant-fold

Conversation

@hzeller

@hzeller hzeller commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller requested a review from a team as a code owner June 8, 2026 14:49
@hzeller hzeller requested a review from maliberty June 8, 2026 14:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors src/syn/test/opt_test.cc by replacing the manual forward declaration of constantFold with the inclusion of the proper header file flow/constant_fold.h. There are no review comments, and I have no additional feedback to provide.

@maliberty

Copy link
Copy Markdown
Member

[2026-06-08T14:53:51.428Z] #11 111.6 /OpenROAD/src/syn/test/opt_test.cc:7:10: fatal error: flow/constant_fold.h: No such file or directory
[2026-06-08T14:53:51.428Z] #11 111.6 7 | #include "flow/constant_fold.h"

@hzeller

hzeller commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

what needs to be changed in CMake to make it happen ? I find cmake terminally unreadable...

@maliberty

Copy link
Copy Markdown
Member

Just ask an AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants