We're not using runfiles anymore, don't use associated macro define.#10634
We're not using runfiles anymore, don't use associated macro define.#10634hzeller wants to merge 3 commits into
Conversation
We used to use runfiles to work with tcl dependencies. Since we don't need that anymore, just add a regular `BAZEL_BUILD` define to choose the behavior in the bazel build and remove the unneeded dependency. Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the preprocessor macro BAZEL_CURRENT_REPOSITORY with BAZEL_BUILD in BUILD.bazel and src/Main.cc. The reviewer feedback highlights several opportunities for cleanup now that Bazel runfiles are no longer used. Specifically, it is recommended to remove obsolete dependencies in BUILD.bazel (@rules_cc//cc/runfiles and @boost.dll), eliminate the unused boost/dll/runtime_symbol_info.hpp header, and completely remove the dead setupBazelRunfilesEnvironment() function and its invocation.
|
Gemini comments seem worth answering/fixing |
|
Yes, I was about to fix these in a separate commit as it was unclear why this was used, as they were added very recently. Peter @gadfort, you recently added these setup runfile functions and I am wondering why ? We're not using tcl from runfiles in a while now, the resources are all compiled-in (since #10094), so the openroad binary can be copied anywhere without needing any runfiles. But the change #10591 looks deliberate, so maybe something else is going on ? Can you shed some light, Peter ? |
Since tcl resources are compmiled-in, we don't need that anymore. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
oops, accidentally added an unrealated boost cleanup into this PR (separate commit), but yeah, might as well keep it here. |
2 participants
We used to use runfiles to work with tcl dependencies. Since we don't need that anymore, just add a regular
BAZEL_BUILDdefine to choose the behavior in the bazel build and remove the unneeded dependency.