Added Johnson's algorithm for all-pairs shortest paths#13340
Open
sangampaudel530 wants to merge 6 commits into
Open
Added Johnson's algorithm for all-pairs shortest paths#13340sangampaudel530 wants to merge 6 commits into
sangampaudel530 wants to merge 6 commits into
Conversation
algorithms-keeper
Bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
Bot
removed
the
require descriptive names
sangampaudel530
changed the title
sangampaudel530
changed the title
Author
|
Hi @cclauss @MaximSmolskiy Could you review this pr and give some feedback. Could you please merge this after reviewing it ? |
Author
|
Hi @cclauss , I wanted to kindly ask if there’s any feedback or required changes for this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new graph algorithm implementation for Johnson’s all-pairs shortest paths, including support for negative edge weights and negative-cycle detection, plus pytest coverage.
Changes:
- Adds
graphs/johnson.pywith Bellman-Ford potentials and repeated Dijkstra runs. - Adds
graphs/tests/test_johnson.pycovering a basic graph and a negative-cycle case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
graphs/johnson.py |
Implements Johnson’s algorithm and helper routines. |
graphs/tests/test_johnson.py |
Adds tests for successful shortest-path computation and negative-cycle rejection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| new_dist = d_u + w_prime | ||
| if new_dist < dist[v]: | ||
| dist[v] = new_dist | ||
| heapq.heappush(heap, (new_dist, v)) |
| def johnson(graph: adjacency) -> dict[Node, dict[Node, float]]: | ||
| """ | ||
| Compute all-pairs shortest paths using Johnson's algorithm. | ||
|
|
Comment on lines
+17
to
+20
| assert math.isclose(dist[0][3], 2.0, abs_tol=1e-9) | ||
| assert math.isclose(dist[3][2], -5.0, abs_tol=1e-9) | ||
|
|
||
|
|
Comment on lines
+88
to
+92
| Example: | ||
| >>> g = { | ||
| ... 0: [(1, 3), (2, 8), (4, -4)], | ||
| ... 1: [(3, 1), (4, 7)], | ||
| ... 2: [(1, 4)], |
| Compute all-pairs shortest paths using Johnson's algorithm. | ||
|
|
||
| Args: | ||
| graph: adjacency list {u: [(v, weight), ...], ...} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR adds Johnson's algorithm for computing all-pairs shortest paths in a weighted graph. The implementation handles graphs with negative edge weights (but no negative cycles) by combining Bellman-Ford and Dijkstra algorithms. A corresponding test file
test_johnson.pyis also included to validate correctness.Checklist: