Skip to content

fix: validate scores length is a power of 2 in minimax #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justin-chiam wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

fix: validate scores length is a power of 2 in minimax #14890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backtracking/minimax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ def minimax(
Traceback (most recent call last):
...
ValueError: Scores cannot be empty
>>> minimax(0, 0, True, [1, 2, 3], 2)
Traceback (most recent call last):
...
ValueError: Number of scores must be a power of 2
>>> scores = [3, 5, 2, 9, 12, 5, 23, 23]
>>> height = math.log(len(scores), 2)
>>> minimax(0, 0, True, scores, height)
Expand All @@ -56,6 +60,8 @@ def minimax(
raise ValueError("Depth cannot be less than 0")
if len(scores) == 0:
raise ValueError("Scores cannot be empty")
if len(scores) & (len(scores) - 1) != 0:
raise ValueError("Number of scores must be a power of 2")

# Base case: If the current depth equals the height of the tree,
# return the score of the current node.
Expand Down