validate sidecar generation promotion#1029
Draft
TheGreenCedar wants to merge 6 commits into
Draft
Conversation
adb6841 to
e6b267f
Compare
e6b267f to
935219d
Compare
935219d to
173371f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Generation fingerprinting and manifest-rooted retention were already transactional, but reuse and rebuild paths did not share one mandatory pre-promotion gate proving that every retrieval component belonged to the same usable candidate.
Closes #1023
Refs #914
What Changed
How To Review
persist_finalized_manifestand confirm all reuse/rebuild paths reachvalidate_candidate_generationbeforepromote_retrieval_manifest.Verification
cargo test -p codestory-retrieval --locked: 339 passed, 2 ignored; integration suites 2/2 bootstrap, 2/2 degraded, 4/4 holdoutcargo clippy -p codestory-retrieval --all-targets --all-features --locked -- -D warningscargo fmt --all --check, documentation links, andgit diff --check3056c1d2and the accelerator-proof blocker fixesRisk
The fingerprint contract bump intentionally rebuilds existing sidecar generations. Native promotion now fails closed when persisted launch identity is stale, replaced, dead, or foreign, and accelerator promotion requires a fresh timed embedding request bound to the exact requested provider/device. Docker promotion also fails if the persisted/running container identity is missing or changes across final probes, and Qdrant supersets are rejected. Explicit CPU policy remains accepted; accelerator inventory/manual assertions alone do not qualify.