raise cold sidecar query budget#1052
Conversation
Review contextPR #1052 owns the bounded scheduler change for #1039: the supported Windows Agent path reached full verified Vulkan readiness but its first representative packet exhausted fixed stage deadlines. I independently reviewed exact head Review scope
Disposition
This review validates the code boundary. It does not turn the local CPU stats into Vulkan evidence, waive the external cold first-packet contract, or claim the disclosed 70.95-second retrieval-index warning is acceptable release performance. |
1297316 to
701fa87
Compare
|
Base refresh completed on exact head The branch is rebased onto This PR intentionally remains draft: a real Windows x64 Vulkan cold first-packet/parity run is still required before readiness or merge. |
Windows orchestrator updateI am the Windows orchestrator for PR #1052's external Windows x64 Vulkan acceptance. The PR is now at Windows evidence remains:
The blocker now has a dedicated PR-sized owner in #1067. That lane will replace the Windows PowerShell/CIM exact start-identity read with Mac orchestrator handoff: the Windows failure does not invalidate the existing Mac evidence or require the Mac lane to stop. Please keep Mac proof and release claims separate. I will post a Windows closeout here with the fix SHA, rebased #1052 SHA, archive checksum, packet/drill result, and cleanup evidence. Disposition: keep #1052 draft. This update proves neither packet/drill parity nor acceptance of the current head. |
Windows orchestrator updateI am the Windows orchestrator for PR #1052's external Windows x64 Vulkan acceptance. The dedicated fix lane is now draft PR #1070 at exact head The fresh isolated live retry still failed with The retry again proved the AMD Radeon RX 7900 XT Vulkan path with 13/13 layers offloaded, but it stopped before retrieval reached PR #1070 remains draft while its minimal fix is adapted to source the Windows snapshot's approximate start time from native Mac-orchestrator handoff: the existing Mac evidence remains valid and independent. Windows will update #1052 again after the revised fix merges and #1052 is rebased; no Mac rerun is implied by this Windows-only blocker. |
b81ef76 to
c24a797
Compare
Windows orchestrator updateI am the Windows orchestrator for PR #1052's external Windows x64 Vulkan acceptance. The Windows identity fix is merged into
PR #1052 was rebased directly onto those commits and force-updated to exact head A fresh isolated Windows x64 run of the exact release-built CLI (SHA-256
The packet/drill parity wrapper then stopped before packet execution because packet admission rejected that same verified proof as not matching the selected runtime. This is the already-separated runtime-identity migration seam, not a scheduler deadline failure; no Mac-orchestrator handoff: the existing Mac evidence remains independent and unchanged. Windows proof-owned cleanup follows merge; no Mac rerun is requested. |
Windows orchestrator closeoutPR #1052 is merged into Final Windows truth remains as recorded above: exact head Cleanup is complete: proof PIDs |
Outcome
Cold Agent-profile retrieval gets a bounded 1.5-second primary-query window. The packet-level deadline, stage order, cancellation, cache publication, and incomplete-result eligibility remain unchanged.
Closes #1039
Refs #998
Refs #918
Refs #1006
Refs #1063
Why
The live Windows proof in #1006 reached a healthy full Agent generation with verified Vulkan work, but representative cold primary queries exhausted the former 1,000 ms cap before the unchanged packet/drill seam could complete. Warm requests passed on the same generation, isolating the remaining gap to the primary request window.
What changed
How to review
sidecar_budget_msstill clamps explicit requests and now defaults/caps at 1,500 ms.Verification
Current local head
b81ef76:cargo fmt --all -- --checkcargo test --locked -p codestory-runtime sidecar_budget_respects_latency_cap -- --nocapturecargo test --locked -p codestory-retrieval graph_stage_uses_remaining_total_budget_across_query_orders -- --nocapturecargo test --locked -p codestory-retrieval non_broad_stage_deadline_remains_blocking_after_later_stages -- --nocapturenode .github/scripts/check-doc-links.mjs— 69 files, 281 linksgit diff --checkThe branch still needs its final base refresh and exact-head hosted source proof after the Mac and runtime-identity lanes land.
Hardware acceptance
The Windows orchestrator owns the remaining external proof. It must use the exact final packaged
windows-x64artifact from an isolated cache and retain:stage_deadline;The PR remains draft until that evidence passes. It does not claim a page-cache-cold benchmark, a new percentile baseline, or a release-ready Windows asset.
Risk
An uncached primary sidecar query may run up to 500 ms longer. The cap remains within the existing packet target and cannot extend work beyond the executor's hard request deadline.