migrate sidecar identity to v3#1059
Merged
TheGreenCedar merged 10 commits intoJul 13, 2026
Merged
Conversation
This was referenced Jul 13, 2026
Owner
Author
Paused review-remediation checkpointExact pushed head: The five review blockers are addressed in the current draft diff:
Green non-Cargo checks:
Cargo verification is incomplete/pending after interrupted compile and formatting attempts. Rustfmt changes were applied. The first focused compile found one unqualified test enum and unused compatibility code; both were fixed. A final import-layout correction was applied after the resumed formatting check, but no Cargo verification ran afterward. Focused tests, workspace check/test/clippy, the two full indexer test binaries, release build, and repo-scale e2e stats still need to run before review readiness. PR remains draft; no merge or readiness transition was performed. |
This was referenced Jul 13, 2026
This was referenced Jul 13, 2026
…034-sidecar-identity-v3 # Conflicts: # .github/scripts/check-packaged-agent-proof.py # CHANGELOG.md # docs/testing/codestory-e2e-stats-log.md
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
CodeStory sidecar state now has one project identity contract across Local, Agent, broker, retrieval, and packaged-proof surfaces. Current state uses schema 3; schema-2 state remains visible for migration inventory but is never reused, trusted, or destructively cleaned as a current runtime.
Closes #1034
Refs #1032
Refs #913
Refs #899
What changed
/bin/sleepexact-identity probe; the deleted speculative fake CLI/cleanup/status matrices were not restored.Final integration
4b8dd7439af0a780e868b7149c7e110530ae431c6c4e7d6aa482cc910c01cdd672d0efe943fa29296ba684a3c2d728aa70ca6893985e6e39f9be8789Verification
Final integrated head:
cargo fmt --all -- --check— passedcargo check -p codestory-cli --locked— passedcargo test -p codestory-retrieval --lib --locked— 362 passed, 2 ignoredpython3 .github/scripts/check-packaged-agent-proof.py --self-test— passednode .github/scripts/check-workflow-policy.mjs— passedgit diff --check— passedEarlier branch evidence includes the mandatory repo-scale full-sidecar rows already recorded in
docs/testing/codestory-e2e-stats-log.md.Simplification review
The final changed-scope Rust review found no safe remaining R0/R1 extraction worth adding to this ownership-sensitive diff. It did consolidate duplicate compatible-result parsing and kept concurrency, process ownership, atomic publication, and filesystem identity code explicit. Larger long-function candidates are pre-existing or cross ownership/concurrency boundaries and are deferred rather than mixed into this PR.
Remaining proof
This cross-platform runtime-identity change receives one unsigned packaged OS matrix at the exact head after the exact-head source gate passes. Signing, notarization, and a duplicate Windows hardware lane are outside this PR's proof dispatch.