Skip to content

[codex] fix protected release-evidence approval#1138

Merged
TheGreenCedar merged 1 commit into
dev/codestory-nextfrom
codex/1137-release-evidence-secret
Jul 14, 2026
Merged

[codex] fix protected release-evidence approval#1138
TheGreenCedar merged 1 commit into
dev/codestory-nextfrom
codex/1137-release-evidence-secret

Conversation

@TheGreenCedar

@TheGreenCedar TheGreenCedar commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • read exception approval directly from the protected release-evidence environment inside the reusable workflow
  • fail before evaluation when a retained-run recheck has no approval
  • structurally require both callers, exact workflow routing, source_run_id forwarding, and no caller secret handoff
  • document the trust boundary and record the required full-sidecar repo metrics

Verification

  • node --test .github/scripts/check-workflow-policy.test.mjs (7/7)
  • node .github/scripts/check-workflow-policy.mjs
  • node scripts/lint-retrieval-generalization.mjs
  • node .github/scripts/check-doc-links.mjs
  • actionlint on the evidence and caller workflows
  • python .github/scripts/check-codestory-release.py --version 0.15.0
  • cargo build --release --locked -p codestory-cli
  • CODESTORY_ALLOW_SKIP_REAL_REPO_DRILL_CASES=1 CODESTORY_EMBED_MODEL_DIR=... cargo test --locked -p codestory-cli --test codestory_repo_e2e_stats -- --ignored --nocapture (2/2; full-sidecar stats emitted)
  • git diff --check

Size

Production workflow: +4/-3. Structural policy: +68/-3. One focused mutation suite: +67. Anti-overfit allowlist: +1/-1. Documentation and required metrics log: +12. No product runtime code changed.

Closes #1137
Refs #1136
Refs #899

@TheGreenCedar TheGreenCedar added the review-accepted Exact PR head accepted for full workspace tests and clippy label Jul 14, 2026
@TheGreenCedar TheGreenCedar moved this from Todo to In Progress in CodeStory Trustworthy Grounding Roadmap Jul 14, 2026
@TheGreenCedar TheGreenCedar force-pushed the codex/1137-release-evidence-secret branch from a04c277 to d4a9431 Compare July 14, 2026 18:38
@TheGreenCedar TheGreenCedar added review-accepted Exact PR head accepted for full workspace tests and clippy and removed review-accepted Exact PR head accepted for full workspace tests and clippy labels Jul 14, 2026
@TheGreenCedar TheGreenCedar merged commit d45b3b3 into dev/codestory-next Jul 14, 2026
28 checks passed
@TheGreenCedar TheGreenCedar deleted the codex/1137-release-evidence-secret branch July 14, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-accepted Exact PR head accepted for full workspace tests and clippy

Projects

Development

Successfully merging this pull request may close these issues.

1 participant