make_future: drop static_assert from detail::make_future

[guptapratykshh]

Proposed Changes

• Replace the static_assert inside detail::make_future(Sender, Allocator) (introduced by make_future: static_assert against silent-hang run_loop_scheduler sender #7248) with HPX_ASSERT_MSG and keep the sender_completion_is_run_loop_scheduler trait that backs it. The static_assert was a hard error during template substitution and broke tag_priority's overload-resolution probing on GCC 12 debug, surfacing in rostam CDash build 53308 on the algorithm_run_loop.cpp test cases that use make_future(just(3) | continues_on(sched)). HPX_ASSERT_MSG is a no-op in release builds and a runtime check in debug, so it does not interfere with substitution, while still flagging the silent-hang misuse during development.
• Add #include <hpx/assert.hpp> to make_future.hpp for HPX_ASSERT_MSG.
• Document the rationale inline: the public make_future CPO's tag_override_invoke overload already routes make_future(run_loop_sender) to the scheduler-form tag_invoke (which builds future_data_with_run_loop and drives loop.run() in execute_deferred), so reaching this 1-arg fallback with a run-loop completion scheduler indicates a direct call to detail::make_future rather than going through the public API; the runtime assert exists to flag that bypass in debug, not to harden release-mode misuse.

Any background context you want to provide?

Checklist

Not all points below apply to all pull requests.

• I have added a new feature and have added tests to go along with it.
• I have fixed a bug and have added a regression test.
• I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[StellarBot]

Can one of the admins verify this patch?

[Copilot]

Pull request overview

This PR removes a non-SFINAE-friendly static_assert (and its helper trait) from detail::make_future(Sender, Allocator) that was introduced to prevent a known runtime hang for run-loop scheduled senders, and replaces it with an explanatory comment. The PR relies on the public make_future CPO’s existing tag_override_invoke routing to ensure run-loop completion schedulers are handled by the scheduler-form overload that drives loop.run().

Changes:

• Removed sender_completion_is_run_loop_scheduler and the static_assert in detail::make_future(Sender, Allocator) that could break GCC 12 debug due to template probing/instantiation.
• Added a comment explaining why the compile-time guard is not present in the fallback and where the actual run-loop driving behavior is implemented.

[hkaiser]

@guptapratykshh Could you turn that static_assert into a runtime assert (HPX_ASSERT)? That will not break compilation of the good cases but will still flag the issue at least at runtime.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[hkaiser]

LGTM, thanks!