feat: implement flat universal parameters for CUT-5149 custom attributes by junioralmeida-82 · Pull Request #746 · TheJumpCloud/support

junioralmeida-82 · 2026-05-28T19:42:01Z

Issues

CUT-5149 - Implement Custom Attributes and CSV Management for Systems

What does this solve?

Set-JCSystem Optimization: Refactored the core function signature to a completely flat parameter structure, removing conflicting ParameterSetName tags to resolve binding intersections.
DynamicParam macOS Fix: Fixed a native PowerShell Core binding issue on macOS where the dynamic parameter block threw ParameterBindingException by ensuring the method returns a validated object dictionary instead of a raw $null when processing exclusions.
New Utility Features: Implemented Update-JCSystemFromCSV and New-JCImportSystemTemplate focused entirely on system infrastructure profiles rather than legacy user nomenclature.
Manifest Alignment: Registered both utility functions into FunctionsToExport inside JumpCloud.psd1.

Is there anything particularly tricky?

Manually verified via local cleanup and search (Cmd+F) that all environment credentials, actual Org IDs, and API keys are completely stripped from the committed codebase files.

How should this be tested?

Execute the official orchestrator targeting the task tag:
& "./Tests/InvokePester.ps1" -JumpCloudApiKey $ApiKey -IncludeTagList "CUT-5149"

Screenshots

Note

Medium Risk
Changes a core cmdlet (Set-JCSystem) and live API PUT behavior for attributes; mistakes could overwrite or drop existing system custom attributes, though merge logic and tests mitigate this.

Overview
Bumps the JumpCloud module to 3.3.0 and extends system management with custom attributes (CUT-5149), aligned with the existing user attribute pattern (NumberOfCustomAttributes + dynamic AttributeN_name / AttributeN_value).

Set-JCSystem gains flat parameters for add/update/remove of custom attributes: it loads current attributes via Get-JCSystem, merges or removes by name, and sends the full attributes array on PUT. A DynamicParam block exposes AttributeN_* when NumberOfCustomAttributes is set, always returning a parameter dictionary (fixes macOS binding when no dynamic params are needed). The API URL now uses $global:JCUrlBasePath.

New-JCDeviceUpdateTemplate accepts NumberOfCustomAttributes (CLI or interactive) to add AttributeN_name / AttributeN_value columns to device update CSVs. Update-JCDeviceFromCSV adds alias Update-JCSystemFromCSV, counts populated attribute columns per row, and passes NumberOfCustomAttributes into Set-JCSystem. New Pester coverage exercises add, merge, and selective remove of system custom attributes.

^{Reviewed by Cursor Bugbot for commit c38ecb6. Bugbot is set up for automated code reviews on this repo. Configure here.}

…e CSV and template functions

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

There are 4 total unresolved issues (including 1 from previous review).

^{Reviewed by Cursor Bugbot for commit 1f3e90c. Configure here.}

gweinjc

Results:
Tested the changes locally, was able to add/remove/update custom attributes on devices.

To-Do:

Docs for each of the changed functions need to be updated to include the new params and examples of how to use them. See the following script to generate the helpfiles: PowerShell/Deploy/Build-HelpFiles.ps1
Missing tests for Update-JCDeviceFromCsv and New-JCDeviceUpdateTemplate
See other in-line comments

gweinjc · 2026-06-04T19:56:05Z

        [Alias('_id', 'id')]
        $SystemID,

-        [Parameter(ValueFromPipelineByPropertyName = $true, HelpMessage = 'The system displayName. The displayName is set to the hostname of the system during agent installation. When the system hostname updates the displayName does not update.')]


Why did we remove all of the HelpMessages from the params?

gweinjc · 2026-06-04T19:59:38Z

+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowMultiFactorAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowPublicKeyAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$systemInsights,
+        [Parameter(ValueFromPipelineByPropertyName = $false)]$primarySystemUser,


Missing HelpMessage

gweinjc · 2026-06-04T19:59:41Z

+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowSshRootLogin,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowMultiFactorAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowPublicKeyAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$systemInsights,


Missing HelpMessage

gweinjc · 2026-06-04T19:59:44Z

+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowSshPasswordAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowSshRootLogin,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowMultiFactorAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowPublicKeyAuthentication,


Missing HelpMessage

gweinjc · 2026-06-04T19:59:48Z

+        [Parameter(ValueFromPipelineByPropertyName = $true)][string]$description,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowSshPasswordAuthentication,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowSshRootLogin,
+        [Parameter(ValueFromPipelineByPropertyName = $true)][bool]$allowMultiFactorAuthentication,


Missing HelpMessage

gweinjc · 2026-06-04T20:06:18Z


-    begin {
+    DynamicParam {
+        # Inicializa o dicionário nativo para evitar falhas de compilação no macOS


May need to remove comments

gweinjc · 2026-06-04T20:06:24Z

+                $dict.Add("Attribute$ParamNumber`_value", $param1)
+            }
+        }
+        # Sempre retorna o objeto (preenchido ou vazio), neutralizando o bug de binding do Mac


May need to remove comments

gweinjc · 2026-06-04T20:06:42Z

-        $Force
+        $Force,
+
+        # CUT-5149: Universal parameter to define the number of custom attributes via CLI.


May need to remove comments

gweinjc · 2026-06-04T20:06:46Z

            elseif ($ConfirmPrimarySystemUser -eq 'N') {
            }

+            # CUT-5149: Assistente interativo por perguntas para incluir colunas de Custom Attributes


May need to remove comments

gweinjc · 2026-06-04T20:07:07Z

                }
            }
+
+            # Injection for CUT-5149: Dynamically calculates the number of Custom Attributes in the current line's CSV.


May need to remove comments

feat: implement flat universal parameters for CUT-5149 custom attributes

9217983

junioralmeida-82 requested review from edgar-lins and jworkmanjc May 28, 2026 19:42

junioralmeida-82 self-assigned this May 28, 2026

junioralmeida-82 requested a review from a team as a code owner May 28, 2026 19:42

junioralmeida-82 added enhancement minor minor version release PowerShell Module Release for JumpCloud PowerShell Module labels May 28, 2026

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread PowerShell/JumpCloud Module/Public/Utilities/CSV_Import/Update-JCSystemFromCSV.ps1 Outdated

jworkmanjc added 2 commits May 28, 2026 14:48

fix tests should parameter

011aa7c

update tests with another case

2017f7f

jworkmanjc changed the base branch from master to v3.3.0_pwshModule May 29, 2026 13:40

refactor: merge system attributes and description into existing devic…

1f3e90c

…e CSV and template functions

cursor Bot reviewed May 29, 2026

View reviewed changes

Comment thread PowerShell/JumpCloud Module/JumpCloud.psd1 Outdated

Comment thread PowerShell/JumpCloud Module/JumpCloud.psd1 Outdated

Comment thread PowerShell/JumpCloud Module/Public/Utilities/CSV_Import/Update-JCDeviceFromCSV.ps1

junioralmeida-82 added 2 commits May 29, 2026 13:03

merge: resolve conflicts with v3.3.0_pwshModule base branch

2175d3b

chore: bump version to 3.3.0 and update release date for CI validation

c38ecb6

jworkmanjc requested a review from gweinjc June 3, 2026 14:20

gweinjc requested changes Jun 4, 2026

View reviewed changes

Conversation

junioralmeida-82 commented May 28, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

What does this solve?

Is there anything particularly tricky?

How should this be tested?

Screenshots

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gweinjc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

junioralmeida-82 commented May 28, 2026 •

edited by cursor Bot

Loading