Remove unused MultiSplit utility and dead sddl/utils package (#84)#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #84Motivation
MultiSplitwas the only symbol in thesddl/utilspackage and had no callers anywhere in the module — a module-wide search found it referenced only by its own test, and no file importedsddl/utils. The live SDDL parser usesstrings.Splitfor field splitting, notMultiSplit. The helper also drops empty fields by design, which is the wrong behavior for the positional SDDL ACE grammar, so it was a latent trap as well as dead weight.What Changed
sddl/utils/utils.go(theMultiSplitfunction).sddl/utils/utils_test.go(its only test).sddl/utilspackage no longer exists, as it contained nothing else.Acceptance Criteria Check
sddl/utils/utils.goandsddl/utils/utils_test.godeleted;sddl/utilspackage removed — both files removed in this PR.go build ./...andgo test ./...pass — verified locally, full suite green.MultiSplitor thesddl/utilsimport path — verified with a module-wide search returning no matches.How Verified
grep -rn "MultiSplit\|sddl/utils" --include=*.go .returns no matches after removal.go build ./...andgo test ./...pass.Test Coverage
Scope of Change
sddl/utils/utils.go,sddl/utils/utils_test.goMultiSplitfunction and thesddl/utilspackage. No in-repo consumers; external importers ofgithub.com/TheManticoreProject/winacl/sddl/utilswould be affected (breaking for them). Please confirm this is acceptable before merging.Risk and Rollout
No runtime behavior changes — the removed code was never invoked. The only risk is to hypothetical external importers of the
sddl/utilspackage; there are none within this repository.