Skip to content

fix(i18n): correct translations and document the POT workflow - #29

Merged
TheStreamCode merged 2 commits into
mainfrom
fix/i18n-consolidation
Oct 28, 2026
Merged

TheStreamCode merged 2 commits into
mainfrom
fix/i18n-consolidation

Conversation

@TheStreamCode

Copy link
Copy Markdown
Owner

Summary

  • Render the relative timestamp through sprintf('%s ago') so French, Spanish, and German can place the time before the marker (previously: "5 min il y a", "5 min hace", "5 min vor").
  • Add the missing preposition in the Italian and French email subjects, use a valid German compound instead of %3-Ereignis.
  • Correct the French folder-move message ("dans lui-même").
  • Align the four localized READMEs with the 3.5.0 fail-closed storage behavior.
  • Standardize Italian terminology: "archiviazione" (not "storage"), "elenco" (not "lista"), "Gestione file" (File Manager); "vault" stays as the product term per locale.
  • Regenerate languages/mikesoft-teamvault.pot with WP-CLI: includes the missing "Only notify people who can access the folder" string, fixes file:line references that were 28 lines stale, removes the build-artifact comment.
  • Document the POT workflow, the pack-over-map precedence, and the terminology decisions; add the POT step to the release checklist.

No storage, permission, REST, schema, or packaging behavior changes.

Test plan

  • php tools/lint-php.php: 88 files, no syntax errors.
  • PHPUnit 11.5.56: 223 tests, 778 assertions, 2 skipped (symlink tests unavailable on this filesystem).
  • node --check on the five admin scripts plus the Plugin Check parser, node --test: 33 passing.
  • i18n coverage replication: 319 source strings, four maps with identical key sets, no missing or unused keys, no placeholder mismatches.
  • POT: 324 entries (319 strings + 5 plugin metadata); spot-checked references resolve to the expected source lines.

The POT diff is large because WP-CLI sorts entries alphabetically and rewrites every reference; it is the canonical generated file.

…erminology

Render the elapsed-time suffix with sprintf('%s ago') so French, Spanish, and German can place the time before the marker, add the missing preposition in the Italian and French email subjects, use a valid German compound, and correct the French folder-move message. Align the four localized READMEs with the 3.5.0 fail-closed storage behavior and standardize Italian terminology (archiviazione, elenco, Gestione file).

Regenerate the POT with wp i18n make-pot so it includes the missing notification string and current file:line references.
Replace the stale load_plugin_textdomain() description, drop the Plural-Forms and custom-extractor notes, document that installed language packs win over the bundled fallback maps, and record the terminology decisions. Add the POT regeneration step to the release checklist and point listing-translation work at the interface-translation guide.
@TheStreamCode
TheStreamCode merged commit 0e72a33 into main Oct 28, 2026
16 checks passed
@TheStreamCode
TheStreamCode deleted the fix/i18n-consolidation branch October 28, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant