Skip to content

Peer home shows two leave lines when the other side leaves a face room #1103

Closed
#1106
Closed
Peer home shows two leave lines when the other side leaves a face room#1103
#1106
Assignees
Birfy
Labels
area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copybugSomething isn't workingself-testFiled by the product self-test routine (issues only)

Description

@Birfy
Birfy
opened on Oct 25, 2026

Reproduce

SelfA1025 / SelfB1025 → https://social.botawaken.com, tip e109361, room 739184:

  1. Both homes Enter chat into the same face room.
  2. On B, Leave this room (confirm).
  3. Watch A's transcript / banners.

Expected

A shows one clear leave / room-closed signal.

Actual

A showed both:

  • SelfB1025 left the room
  • banner SelfB1025 left the room. Room closed.

Shot: /workspace/social-ui-deep-test/retest-round/r08-a-room-closed-after-b-left.png.

Environment

Source

product UI retest round 2026-10-25 (owner: file + fix)

Activity

  1. Birfy
    self-assigned this
    on Oct 25, 2026
  2. Birfy
    added
    bugSomething isn't working
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    self-testFiled by the product self-test routine (issues only)
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 25, 2026

  3. Birfy commented on Oct 25, 2026

    @Birfy
    Birfy
    on Oct 25, 2026 – with Cursor
    CollaboratorAuthor

    Claiming. Branch: fix/1103-dedupe-face-leave

    Written-by: Coordinator

  4. cursor
    added 3 commits that reference this issue on Oct 25, 2026

    Show one leave line when a face room closes (#1103)

    6f6fe5a

    Show one leave line when a face room closes (#1103)

    6930384

    Show one leave line when a face room closes (#1103)

    89553d2
  5. Birfy
    added a commit that references this issue on Oct 25, 2026

    fix(social): one leave line when a face room closes (#1103)

    e2a4a41
  6. Birfy
    closed this as completedin #1106on Oct 25, 2026
  7. Birfy
    removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 25, 2026

  8. Birfy commented on Oct 25, 2026

    @Birfy
    Birfy
    on Oct 25, 2026
    CollaboratorAuthor

    done — four checks on c653a5dc (current main, merge of #1106 @ e2a4a41f):

    1. #1103 closed/completed; Fixes #1103 -> #1106 merged: true, merge commit c653a5dc.
    2. changelog.d/1103-face-leave-single-line.fixed.md on main (335 B).
    3. Docs on main: docs/subsystems/social.md — face room status line data-flybot=face-room-end: "A leave that closes the room is that one line (Peer home shows two leave lines when the other side leaves a face room #1103): the shorter Bob left the room is not also posted"; docs/subsystems/core-client.md — "A closed face room status line already says who left (Peer home shows two leave lines when the other side leaves a face room #1103)" plus the leaveNoticeCoveredByClose mention.
    4. Code on main: core/src/client/cells.js has leaveNoticeCoveredByClose, plugins/social/src/face-rooms.js carries the leave handling, and the bundle core/client.js matches (build-client --check exit 0 at the tip).

    Labels: agent-working off this issue, agent-pr off #1106; agent-ready left for Triage.

  9. Birfy
    removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copybugSomething isn't workingself-testFiled by the product self-test routine (issues only)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions