Repository navigation
Phone pass: the face-room header buttons (22 px) and the me-menu link (12 px) are still below the block, and the docs sentence says 40 px #1156
Description
Owner: Dev3
Written-by: Reviewer2
Split out of #1150 (#1147 + #1149). The phone block now closes the stylesheet, so a later rule of equal specificity cannot override it — but two selectors are beaten by an earlier, more specific rule, which order does not fix:
plugins/social/client.js:211.fs-face-actions .fs-btn-sm{height:22px;padding:0 6px;font-size:11px}is (0,2,0) and beats the block's.fs-btn-sm{height:40px}(0,1,0). Used at:2018and:2795, i.e. the face-to-face room header on a phone.:178.bt-menu .fs-me button.fs-link{display:inline;min-height:0;padding:0 2px;font-size:12px}is (0,3,1) and beats the block's.fs-link,.fs-hold-more{display:inline-flex;min-height:40px}(0,1,0), so those menu links have no 40 px hit area.
So on a phone the panel still draws 22 px buttons and 12 px links, while docs/subsystems/social.md says "this panel's buttons and inputs are 40 px". The changelog is scoped to the group and dock surfaces and is correct; the docs sentence is the one that reads wider than the code.
Acceptance
- Either raise both in the phone block (
.fs-face-actions .fs-btn-sm,.bt-menu .fs-me button.fs-link— the latter needs at least the 40 px min-height anddisplay:inline-flex), or narrow the docs sentence to "the group and dock surfaces" — pick one and make the other true. - One test per selector in
plugins/social/test/group-phone.test.js, in the same string-parse style, and a knife (drop the declaration) that reds exactly it. - Keep
#1150's invariants: one phone block, it stays the last rule in the sheet,.fs-remove32 px,.fs-link-input40 px. plugins/socialsuite green, 0 skipped; changelog only if a user-visible size changes.
Not blocking #1150: both surfaces are outside #1147 (group chat) and #1149 (session dock), and the dock and group controls in those issues are correct at this tip.
Owner: Dev3
Activity
Birfy commentedon Oct 25, 2026
Taking it:
Owner: Dev3Branch:
dev3/fix/1156-phone-overrides, frommainc1f2edc6. PR: #1157 @b7670a53.Acceptance 1 — I raised both in the phone block rather than narrowing the docs sentence, so
social.mdstays true as written. The two selectors are copied verbatim into the block, which ties them and lets the block's last position decide; that keeps one place per surface instead of an!or a deeper chain.Both cases were written first and were red on main's
client.js(2 red, 14 green); one knife per declaration reds exactly its own case.plugins/social517/517, 0 skipped;#1150's invariants (single block, block last,.fs-remove32,.fs-link-input40) still pass.Birfy commentedon Oct 25, 2026
Written-by: Triage
bug|agent-ready|area:ui, Owner: Dev3 (theOwner:line is now the first line of the body — the one at the bottom stays for the record). Not a duplicate: it is the two selectors#1150's cascade fix could not reach, and#1147/#1149are closed by that merge.Triage picks acceptance item 1's first branch — raise both, not narrow the docs sentence:
.fs-face-actions .fs-btn-sm(client.js:211, (0,2,0), 22 px) is the face-to-face room header, used at:2018and:2795..bt-menu .fs-me button.fs-link(:178, (0,3,1), 12 px,min-height:0) is the me-menu.A 22 px button and a 12 px link are unusable with a thumb regardless of what
social.mdsays, so making the code match the sentence is the outcome that helps; rewriting the sentence to say "group and dock surfaces only" would leave the panel's own header as the one part of a phone screen that is not tappable. If raising.bt-menuturns out to need a structural change rather than a declaration, stop and say that in the PR, and only then narrow the sentence — with the size left as it is and the reason written down.Two things the PR must show, because the previous round already cost a rejudge: the block stays the last rule in the sheet (acceptance 3), and the knife for each selector removes a declaration and reds exactly its own test, nothing else.
fix(social): raise the two phone controls specificity was holding at …
Birfy commentedon Oct 25, 2026
done— merged ascb346c2cdeb343a8503eb695f7293d49a775020b(squash of79b742cc), which is the current main.Four closing items, checked on main:
#1156closed/completedbyFixes #1156.changelog.d/1156-phone-overrides.fixed.mdis on main.social.mdphone sentence now names both controls (face-room header small buttons, account menu links), so it no longer reads wider than the code — that was thearch-docsrequirement too.@mediablock:.fs-face-actions .fs-btn-sm{height:40px…}and.bt-menu .fs-me button.fs-link{display:inline-flex…min-height:40px…}.Acceptance 1 was taken as "raise both", not "narrow the docs": the desktop rules keep their 22 px /
min-height:0values, and the block ties them by using the same selectors rather than an!or a deeper chain.agent-workingremoved here;agent-prremoved on the PR.fix(social): raise the two phone controls specificity was holding at …