Repository navigation
docs(workflow): finish the Tools/README wording left over from #1523 (after #1535) #1548
Description
Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.
Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 497f1db8119741a399e9f75e3cb94386
Branch: dev/1-1523-wording-leftover
Base: 6202359
At: 2026-10-28T04:09:41Z
Implementation: FlyBot (ours) — PR follows within 24h after its gate opens (see "When"). Do not pick up without a pickup-ok comment.
Written-by: FlyBot Lead
Why this is a separate issue
#1523 was closed on 2026-10-28 (comment 6459826882) because its whole premise — "spawn does not hand tools to the run Bot" — becomes false the moment #1535 lands. Four pieces of its content are still worth doing afterwards, and they are the only survivors of that PR. This issue is the record: the comment sinks with the closed PR, this does not.
Do not start before #1535 is merged. All four touch files #1535 edits (plugins/workflow/client.js, README.md, src/template.js); starting earlier means rebasing into a moving target and re-verifying twice.
The four items
plugins/workflow/client.js— the Tools field has no explanation. The placeholder still saysgithub, bash, read, edit..., which mixes real connector ids (github,composio) with shell/file words that a node'stoolscannot grant. Say what the field does after fix(workflow): a node's tools selects connectors instead of granting everything #1535: it selects the connectors the run Bot may use; file/shell access is the same for every node Bot and does not come from this field.plugins/workflow/client.js— the i18n stringEach Bot's own permissionis now wrong. Since fix(workflow): a node's tools selects connectors instead of granting everything #1535 every node Bot is created withdanger-full-access, so permissions do not vary per Bot. Replace the string (and its translation) with what actually varies per node: the connector list.plugins/workflow/README.md:37— the bash note reads as if it is in effect.Its Coder and Tester carry a bash note, and its Coder, Reviewer and Deployer carry a github note— after fix(workflow): a node's tools selects connectors instead of granting everything #1535 only the github note grants anything;bashintoolsis inert becausepermissionFor()is alwaysdanger-full-access. Reword so the github note is the one that does something.plugins/workflow/src/template.js:20and:34— shell/file words sit in the connector list. Coder istools: ['github', 'bash', 'read', 'edit']and Tester['bash']. If the wording in items 1–3 says this field is about connectors, the template should not model file/shell words in it. Cleaning the template is optional; if done, it must change the assertions fix(workflow): a node's tools selects connectors instead of granting everything #1535 pinned inplugins/workflow/test/ephemeral.test.js(the built-in delivery nodes hand their connector list to the host:coder === ['github','bash','read','edit'],tester === ['bash']) in the same PR, or CI goes red.
Scope
- Wording only in items 1–3; item 4 is a data change in the built-in template plus the pinned assertions, and can be dropped if the wording solution keeps
bash/read/editmeaningful. - No permission behaviour changes: the run Bot's
permissionstaysdanger-full-access, and connector access still comes fromnode.toolsonly. npm run verifygreen; if item 4 is included,plugins/workflowtests updated in the same commit.
Out of scope
The exchange-panel defects (core/src/client/exchange.js half-fence copy, and the "does not follow a new line" enhancement) are separate items in the backlog, not this issue.
Activity
HugoXK commentedon Oct 28, 2026
Claim
Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 497f1db8119741a399e9f75e3cb94386
Branch: dev/1-1523-wording-leftover
Base: 6202359
docs(workflow): finish the tools wording left over from ThinkFlowLab#…
docs(workflow): finish the tools wording left over from ThinkFlowLab#…
Birfy commentedon Oct 28, 2026
Written-by: Triage
Label repair at 2026-10-28T10:50:39Z:
agent-pradded — this issue's open pull request is #1560 (forkHugoXK/FlyBot), headb9ee22471e54bc5027d7243bbf87df2e5fa862bb. Implementation stays on the pull request line; nothing new starts from this issue.Birfy commentedon Oct 28, 2026
Written-by: Chief
The pull request for this issue (#1560) had its head on the author's fork (
HugoXK/FlyBot), which we cannot push to, so its branch could not be rebased and had goneCONFLICTINGagainstmain.Per the owner decision of 2026-10-28 it was replayed onto current
mainin this repository and reopened as #1589 (branchreplay/pr-1560) with the same eight files. #1560 is closed as superseded; the work continues in #1589.docs(workflow): finish the Tools wording left over from ThinkFlowLab#…