Share a Bot with an existing friend without an invite link #500

Activity

1. Birfy

   added

   enhancementNew feature or requestNew feature or request

   needs-humanThe agent loop stopped; a person must decide (reason in the last comment)The agent loop stopped; a person must decide (reason in the last comment)

   area:socialFriends, invites, grants, Bot SocialFriends, invites, grants, Bot Social

   on Oct 20, 2026
2. Birfy commented on Oct 20, 2026

   

   Birfy

   on Oct 20, 2026

   CollaboratorAuthor

   More actions

   Triage (2026-10-20 13:56 Asia/Shanghai, Birfy maintenance). Proposed scope: Bot Social gets an owner-only 'grant this Bot to an existing friend' call (Birfy/bot-social#34); FlyBot adds a Share with a friend list in the Bot's Sharing panel (current friends who don't have this Bot yet, one click each), and the new share shows up in People with access with Revoke. The friend can decline as today. Invite links for new people stay. Waiting for the owner's confirmation (build now vs keep deferred); then both issues get agent-ready.
3. Birfy commented on Oct 20, 2026

   

   Birfy

   on Oct 20, 2026

   CollaboratorAuthor

   More actions

   Owner decision (Danyang Chen, confirmed 2026-10-20 14:30 Asia/Shanghai): option (a) — build now, server + FlyBot together.

   • Bot Social (Grant an existing friend access to a Bot without an invite code (for FlyBot #500) Birfy/bot-social#34): add an owner-only call that grants an existing friend access to that one Bot. It creates the same per-Bot grant kind that invite acceptance creates; the friend can decline, and the owner can revoke.
   • FlyBot (Share a Bot with an existing friend without an invite link #500): add a "Share with a friend" list in the Bot's Sharing panel showing friends who don't have the Bot yet; the new share appears in "People with access".

   No invite link needed. Removing needs-human, adding agent-ready.
4. Birfy

   added

   agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a templateMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template

   agent-workingAn agent has claimed this issue (the claim comment names the branch)An agent has claimed this issue (the claim comment names the branch)

   and removed

   needs-humanThe agent loop stopped; a person must decide (reason in the last comment)The agent loop stopped; a person must decide (reason in the last comment)

   on Oct 20, 2026
5. Birfy

   self-assigned this

   on Oct 20, 2026
6. Birfy commented on Oct 20, 2026

   

   Birfy

   on Oct 20, 2026

   CollaboratorAuthor

   More actions

   Claimed 2026-10-20 14:55 Asia/Shanghai for development on branch feat/500-share-with-friend (local worker; cloud agents unavailable in region). Companion: Birfy/bot-social#34.
7. Birfy commented on Oct 20, 2026

   

   Birfy

   on Oct 20, 2026

   CollaboratorAuthor

   More actions

   Minor decisions (development, 2026-10-20 Asia/Shanghai):

   • Sharing panel order: Invite to this Bot (new people) → Share with a friend (existing) → People with access.
   • Candidates come from active list_friends friendships minus homes already in this Bot's People with access (so a friend we invited who has not shared anything back still appears).
   • Client sends both friend_home (always available) and friend_owner_id when Bot Social exposes it on the peer; companion Grant an existing friend access to a Bot without an invite code (for FlyBot #500) Birfy/bot-social#34.
   • Older servers without grant_bot_to_friend: English notice that Bot Social needs an update; invite links unchanged.

   PR: #516
8. Birfy

   closed this as completedin #516on Oct 20, 2026
9. Birfy commented on Oct 20, 2026

   

   Birfy

   on Oct 20, 2026

   CollaboratorAuthor

   More actions

   Cleanup: fix PR for #500 merged to main (share with existing friend). Removing agent-working and assignee.
10. Birfy

    removed their assignment

    on Oct 20, 2026
11. Birfy

    removed

    agent-workingAn agent has claimed this issue (the claim comment names the branch)An agent has claimed this issue (the claim comment names the branch)

    on Oct 20, 2026
12. Birfy

    added 4 commits that reference this issue on Oct 20, 2026

    Share a Bot with an existing friend from Sharing (ThinkFlowLab#516)

    ...

    This issue will close once commit aec6428 is merged into the 'main' branch.

    aec6428

    Merge origin/main into fix/499-invite-friendchat-polish

    ...

    This issue will close once commit eaed3f1 is merged into the 'main' branch.

    eaed3f1

    Merge origin/main into fix/506-invite-copy-leftovers

    ...

    This issue will close once commit 9fdb694 is merged into the 'main' branch.

    9fdb694

    Social: neutral 'You already have …' on a re-accepted invite; clearer…

    ...

    This issue will close once commit eb91742 is merged into the 'main' branch.

    eb91742
13. Birfy

    removed

    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a templateMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template

    on Oct 21, 2026
14. Birfy commented on Oct 21, 2026

    

    Birfy

    on Oct 21, 2026

    CollaboratorAuthor

    More actions

    Relation to #592 (option A, landed today): this issue was closed as completed on 2026-10-20, before the capability it asks for actually worked. What it wanted — sharing a Bot with an existing friend without an invite link — only became true today, when both ends were aligned:

    • Birfy/bot-social PR ci: turn off CodeQL #38 (squash 82bcc0c1): grant_bot_to_friend accepts the peer's bot_id from list_friends and derives the owner, so a friend you never exchanged owner ids with can be shared with. Marked awaiting-deploy; not deployed yet.
    • FlyBot PR Share with a friend by the peer Bot id (#592) #600 (squash f2b461f0): the flybot social plugin sends that bot_id, its REST fallback hits the server's real route /v1/bots/{id}/grants, and a refusal now reads as a plain line.

    The closing reason stands (no follow-up work needed here); the entry is so the trail shows the feature was not actually usable until #592's fix, and so the one remaining step — deploying the server build — is not lost.
15. HugoXK

    added 2 commits that reference this issue on Oct 24, 2026

    Keep the share list when a read fails or races a revoke (ThinkFlowLab…

    ...

    99cbb1a

    Restore both directions when a re-invite is accepted (ThinkFlowLab#1000…

    ...

    db56b81