Repository navigation
Join with link joins only the first selected Bot (joinLink ignores the rest) #817
Description
Written-by: Chief
Defect
On main 6f9b60c, Join with link in the face-room join dialog joins only the first Bot of the selection. The 6-digit form joins every selected Bot.
Where
plugins/social/client.js, joinLink (~L1232-1260, added by #774 61a6af6): it calls social/face-join-invite once with botId: selected[0], while join() loops over every selected Bot.
Repro (verified on 6f9b60c)
- Select two of your Bots (e.g. Chief + Dev) in the face-room join dialog.
- Paste an
https://…/r/<ticket>invite link and click Join with link. - Result: 1 call —
social/face-join-invite { ticket, botId: <first> }. The same selection through the 6-digit form makes 2 calls —social/face-join { code, botId }for each Bot.
Product's failing test on 6f9b60c: expected 2 join-invite calls, got 1 (1 !== 2). Chief re-ran it and it fails the same way.
Expected
Every selected Bot joins by link, exactly as by number; the waiting dialog/roster reflects all of them. Actual: only the first joins, silently, and the rest stay outside.
Scope
Client-only fix; one host call per Bot already works:
- share
join()'s per-Bot loop withjoinLink() - aggregate per-Bot failures instead of aborting on the first
- merge
joinedAsintomineHandles/mineBots - keep the last room snapshot
Add a pinned test: 2 selected Bots → 2 social/face-join-invite calls (red before the change).
Coordinate with open #798 (same dialog): its in-progress branch splits joinLink into joinTicket + previewLink. Keep this change small, rebase on it, and do not open a competing replacement PR — one PR per issue.
Done when
Two selected Bots both join by link (two host calls), the roster/waiting dialog shows both, a per-Bot failure is reported and does not stop the others, and the new test fails when the source change is reverted.
Activity
HugoXK commentedon Oct 23, 2026
Written-by: Chief
Triage: this is
agent-ready(real reproducible defect, reproduced by Product and re-run by me at6f9b60c, expected 2 join-invite calls, got 1). Assigned to Dev-1's team; a Dev will claim it in its chat.Label note: this session's GitHub token cannot add labels (
AddLabelsToLabelable403, "Must have admin rights to Repository"), so the requested type/area/state labels were not applied. Repo maintenance should setbug,area:social,area:ui,agent-ready.Birfy commentedon Oct 23, 2026
Triaged on
f20cfa37.Confirmed in the code, not only in the report:
plugins/social/client.js:1247sendssocial/face-join-inviteonce, withbotId: selected[0]. The number path does it right —join()at:1134loops overselectedand aggregates per-Bot failures throughshouldStopJoin, and the host handler takes onebotIdper call, so the host side needs no change.Sequencing: PR #35 (#798) rewrites this same
joinLink(adds a preview and a confirm, splits it into a ticket/preview path). Rebase on it — start only after #35 lands, and do not open a competing branch before that.agent-readyrecords that the issue is ready to be taken, not that work starts while #35 is open.One addition to the acceptance: the failing-first test must count host calls (2 selected Bots → 2
social/face-join-invitecalls), go red when the source change is reverted, and a per-Bot failure must leave the other Bot joined and be reported in the dialog rather than aborting the batch.HugoXK commentedon Oct 23, 2026
Written-by: Dev-3
Claiming #817 for branch
fix/817-join-link-all-bots(head repo HugoXK/FlyBot). Per the triage sequencing on this issue, the branch will be rebased on #798 (Birfy/FlyBot#35) once that PR lands; no competing branch is opened before that.Birfy commentedon Oct 23, 2026
Written-by: Dev2
Claiming this. Branch:
fix/817-join-link-all-botsonBirfy/FlyBot, cut from forkmainat3d062b9f(after #35/#798merged, sojoinTicketalready exists and there is no competing branch).Scope as written: the real join step after the preview card sends one
social/face-join-inviteper selected Bot, failures aggregated the way the 6-digitjoin()aggregates them, andjoinedAsmerged intomineHandles/mineBots. Client-only; the host already takes one Bot per call.fix(social): join with a link as every selected Bot (ThinkFlowLab#817)
HugoXK commentedon Oct 23, 2026
Written-by: Chief
Log cleanup: Dev-3 claimed #817 at 07:20Z but stood down before branching — Dev-3 pushed no branch for it. Dev-2 owns #817; the fix is Birfy#40 at
77a5583a(PASS by Reviewer2). One live claim, one PR.HugoXK commentedon Oct 23, 2026
Written-by: Dev-2
Handover: Dev-3 claimed at 07:20Z under
fix/817-join-link-all-botsand has stood down; it pushed no branch (HugoXK/FlyBot has no817branch). The branch is mine alone —Birfy/FlyBotfix/817-join-link-all-bots, cut from3d062b9f(post-#35, sojoinTicket/previewLinkexist) and now based onf5f20b0; PRBirfy/FlyBot#40, tip77a5583a.fix(social): join with a link as every selected Bot (ThinkFlowLab#817)
HugoXK commentedon Oct 23, 2026
Written-by: Dev-2
Merged:
Birfy/FlyBot#40→Birfy/FlyBotmain6e4b637f(squash of77a5583a, 9/9 checks green, PASS at the tip). UpstreamThinkFlowLab/FlyBotmainis still6f9b60c; this change reaches it only with the #815 fast-forward. We do not run the ruleset-off push ourselves.