Skip to content

A face-room invite preview says "A room with no name" for every room FlyBot creates #859

Closed

Description

@Birfy

What is wrong

The invite preview card's title line reads A room with no name whenever Bot Social has no name for the room, which is every room created from FlyBot.

  • plugins/social/client.js:1532 — preview.name || 'A room with no name'.
  • The server's preview answer for these rooms carries "name": null (measured on social.botawaken.com in Face-room invite preview renders the room lead as "object Object" #846), and previewInvite maps that to '' (plugins/social/src/face-rooms.js:699).
  • Nothing in this repo sends a name to Bot Social: a room is opened with POST /v1/face-rooms/join and a body of { code, bots } (face-rooms.js:721) — there is no name field. FlyBot's own title (formatFaceRoomTitle, plugins/social/src/face-title.js, e.g. Face-to-face · SelfTest A2, SelfTest B2 · 988036) is generated locally and never goes on the wire.

So the card reads:

A room with no name
Lead: Chief (SelfTest A2)
2 / 8 in the room
9:53 left to join

The other three lines are right; the first one reports the absence of a name as if something broke, which is the first thing a person sees before deciding to join.

Expected

When the server has no name, the title line names what kind of room it is instead of reporting a missing field. The wording settled on here is Face-to-face room:

Face-to-face room
Lead: Chief (SelfTest A2)
2 / 8 in the room
9:53 left to join

The Lead: line and the count are what actually identify the room to the person joining, and both already work (#846 fixed the lead). Nothing else about the card changes.

Do not invent a name from the ticket: the ticket is opaque, and the local title cannot be rebuilt on the invited side — that home has no member list and no room code.

Scope

  • plugins/social/client.js:1532 — the fallback string only.
  • plugins/social/test/social.test.js — the preview-card cases around :9200-9254 already assert face-link-preview-name for a named room (Kitchen sync). Add the empty-name case: the server answers name: '', and the card draws Face-to-face room.
  • One changelog.d/ fragment, Fixes #<this>.

Acceptance

  1. A preview whose answer has name: '' (and one with name: null) draws Face-to-face room, not A room with no name.
  2. The existing named-room case still draws its name unchanged (Kitchen sync), and the Lead: / n / 8 in the room / expiry lines are untouched.
  3. The literal A room with no name no longer appears anywhere in plugins/social/.
  4. Negative control: restoring the old literal reds only the empty-name case, and the named-room case stays green.

Not this issue

Activity

  1. added
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    enhancementNew feature or request
    on Oct 23, 2026
  2. HugoXK commented on Oct 23, 2026

    @HugoXK
    Contributor

    Written-by: Dev-3

    Claiming #859 for Dev3 — checked first: no linked PR, no assignee, no agent-working.

    • Branch: dev3/fix/859-face-room-preview-fallback
    • Base: fb38c4b037f1d7804254ce1d2e6e859e05a1aa5e (current main)
    • Scope exactly as the issue writes it: the fallback literal at plugins/social/client.js:1532 becomes Face-to-face room when the server's name is empty/null; add the empty-name preview-card case (and the null answer) to plugins/social/test/social.test.js around the existing named-room case; one changelog.d/ fragment.
    • Test first: the empty-name case goes red against the old literal before the change, and the named-room case (Kitchen sync) stays green.

    No wider change; nothing pushed yet.

  3. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    and removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 23, 2026
  4. Birfy commented on Oct 23, 2026

    @Birfy
    CollaboratorAuthor

    Claimed by Dev (FlyBot). PR: #860 @ 7e01d0d4, branch fix/859-preview-room-title from main fb38c4b0.

    Scope kept exactly to the card's first line: preview.name || 'Face-to-face room' in plugins/social/client.js:1532, plus one case covering name: '' and name: null that also asserts the lead, the count and the deadline are unchanged. No name is invented from the ticket (it is opaque and the invited side has no member list or room code), so the real title still needs a bot-social change; that stays out of this issue.

  5. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copyenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions