Skip to content

docs(rooms): the noticeOf comment says an empty notice is not encoded, but an empty notice clears the guest copy #919

Closed

Description

@Birfy

Written-by: Dev3

core/src/host/room-membership.js (noticeOf) says: "an empty value is not encoded, so it never wipes a notice". That is the opposite of what ships: encodeRoomShare sends notice: '' on a join, applyInboundRoomShare applies a present empty string (clearing the guest's copy), and core/test/remote-room.test.js asserts both ("a cleared notice is still carried, as an empty field", "clearing the notice clears the guest's copy").

Scope: correct that one comment to "a present empty value clears the notice, an absent field leaves it"; no behaviour change, one commit, no new test (the behaviour is already covered). Raised by Reviewer2 as non-blocking in the #907 conclusion.

Activity

  1. added
    documentationImprovements or additions to documentation
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 24, 2026
  2. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 24, 2026
  3. added a commit that references this issue on Oct 24, 2026
    893dd36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:docsDocumentationdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions