Repository navigation
Send a JSON body when Enter chat starts a face room - #1098
Merged
Merged
Conversation
Enter chat POSTs /v1/face-rooms/:id/start with no body. The deployed Bot Social answers 500 "internal error" for that request before the handler runs, and both homes show it in the waiting dialog. An empty JSON object reaches the handler. Docs-not-needed: the face-room request body is not an architecture change. Co-authored-by: Danyang Chen <birfychen@gmail.com>
Collaborator
Author
|
Verdict: PASS at 5eee4ac Fixes #1085. Face-room POST/PUT/PATCH without a body now send Ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1085
What changed
Enter chat calls
POST /v1/face-rooms/:id/startwith no body. On https://social.botawaken.com that request is HTTP 500{ code: "internal_error", message: "internal error" }before auth, and the waiting dialog shows that string. The same POST with{}reaches the handler. Face-room POST, PUT, and PATCH calls that omit a body now send{}.Docs-not-needed: the face-room request body is not an architecture change.
Verification at the tip
Tip SHA: 5eee4ac
Fail-without-change: on the unbroken tip,
node --import ./test/resolve.mjs --test --test-name-pattern '#1085' test/face-rooms.test.jsin plugins/social failed with message "internal error" (code internal_error). After the callHttp change the same test passes.Ran:
TZ=UTC npm run verify(exit 0). core lint and arch-docs OK; plugins lint OK; client.js check OK; 10 patches apply; core equals ds-bot + patches. core tests 1439 pass / 0 fail; social 476 pass / 0 fail (includes #1085); tree 125 pass / 0 fail; timeline 125 pass / 0 fail; .github/scripts 417 pass / 0 fail; interop 37 pass / 0 fail; live-e2e 16 pass / 0 fail. After the commit,node core/scripts/check-arch-docs.mjsreported OK (3 changed files) andnode .github/scripts/changelog.mjs checkreported the fragments well formed.Not run: smoke (no core/index.js or src/host change). Desktop. A live face room on Social (the production probe was unauthenticated: a bodyless POST /start returned 500 internal error, and the same POST with
{}returned 401 and reached the handler).Self-review note
Implementer only. No Verdict. PASS and enqueue stay with the coordinator.
Not enqueued.