[Birfy]

Owner: Dev4
Reviewer: Reviewer2

Fixes #1212
Tip SHA: 166418c

A day that read zero and a day the host could not read looked the same in the Delivery header. Each countable metric now draws its own seven-day line, and every drawn point says which of the two it is: full, or partial for today while the day is still running. A 0 is a filled dot on the baseline; a day with no number draws no dot and the line breaks there.

Rebased onto 00bd3820. Both rewrites of this view are kept whole: #1219's read states (loading counter, stale board, failed board with Retry, the Diagnose block, createPoller, pollDelay, the [0, 10_000, 40_000, 160_000] cadence) and #1232's countdown (a one-second tick only while failed/stale carries a retryAt, cleared on unmount or when the state changes, and the three hints that say "while this page is open"). All sixteen delivery-view.test.js cases from those two tips still run, including the 120 → 119 countdown and the string scan that keeps the old "It retries on its own (10 s → 30 s → 2 min)." sentence out. Only the metrics table is replaced by the chart.

Reproduce

Today's header is one table: label | Today | 7 days. A day the host could not read and a day with 0 both arrive as numbers, so nothing on screen tells "no new issues" from "we could not read GitHub". And the two totals sit side by side in the same weight, so 4 beside 30 reads as a 70% drop.

What changed

• core/src/client/delivery-chart.js (new): pure geometry (chartDays, dayValue, chartGeometry, knownDays, todayPartial, dayLabel, pointTitle), <DeliveryChart>, <DeliveryMetrics>, DELIVERY_CHART_CSS. One 168×28 SVG per metric, both breakpoints, y from 0 (span = max(known)), 1.5px stroke, r=2 dots with a title on each.
• The point states are drawn, not styled by guesswork: a day with no number draws no dot at all and the path breaks there, so a gap can never be read as a dip to zero; a real 0 is a filled dot on the baseline; today with partial: true is a hollow r=2.5 dot (fill:none, stroke-width:1.5) and its stretch is stroke-dasharray: 2 2. Each drawn dot carries data-state="full|partial" — missing is a geometry state, not an element, because the missing day has no node to carry it.
• One line per countable metric. metricRows() builds seven rows: the four counts, the CI red share (today/week as a percentage of the runs that counted, — when nothing counted), then the two medians. The CI row is what makes that line reachable in the product — before it, CHART_KEYS had 'ci' and only a hand-built test row could draw it.
• One primary number per row. Σ only on the week number of the four counting rows (COUNTING_KEYS), in --bt-ink-3; the shared header carries no Σ; the CI share is a ratio and keeps its number plain, starving only when its window is incomplete; the two median rows get no line, no placeholder and no total. A count over a window with unread days wears a star (40*), and one foot line says * 5 of 7 days had data — the window length interpolated, not hard-coded.
• One partial hint, in the as-of line. The shared header always says Today; 今天为部分日 · 截至 HH:mm is merged into the existing as of row (DeliveryHeader), so the block never says it twice.
• core/src/client/delivery-view.js: the metrics table becomes one <DeliveryMetrics rows daily> call inside the DeliveryHeader that #1219 and #1232 rewrote; every row carries key so the chart finds its series by name, not by position. Nothing else in that file changed — the poller, the countdown tick, the hints and the Diagnose block are theirs; DELIVERY_CSS + DELIVERY_CHART_CSS.
• Layout: 1080px inline; below 900px the line moves under its row (row height 16 → 44). No host timer added — delivery-board.test.js:539 ("the host installs no timer") is untouched and green.
• Tests: core/test/delivery-chart.test.js (new) plus seven keys in delivery-view.test.js's deep compare, and a new case that walks the rendered board and finds a chart on every countable metric — ci among them — with no chart on either median row. changelog.d/1212-delivery-charts.added.md (168×28, below 900px; a count's week number is a Σ, the ratio never takes one) and one row in docs/subsystems/core-client.md.

The metrics.daily contract this reads (host half is separate, #1222):

{ date, partial?, newIssues, closedIssues, newPullRequests, mergedPullRequests, ci: { failed, counted, total } }

• A day that could not be read is null, never 0. 0 is a measurement; null is the absence of one, and they are drawn differently (baseline dot vs no dot with a broken line).
• partial: true only on today, until the day is over.
• No metrics.daily at all (until #1222 lands) → the block draws no SVG and says 7 天数据未取到 in one line. It never draws seven zeros.
• The chart reads payload.metrics.daily — DeliveryHeader receives the whole view, whose numbers live under metrics; reading payload.daily would render the empty state for every real snapshot.

Verification at the tip

Tip SHA: 166418c

Ran:

node core/scripts/build-client.mjs            # rebuild the bundle, not --check
node core/scripts/build-client.mjs --check
node --test --import ./core/test/harness-resolve.mjs \
  core/test/delivery-chart.test.js core/test/delivery-view.test.js core/test/delivery-board.test.js \
  core/test/kanban.test.js core/test/client-bundle.test.js core/test/i18n.test.js
node scripts/ds-bot-patches.mjs check

• build-client → exit 0 (rebuilt), --check → exit 0 (the committed bundle is what src/client builds).
• The six test files → 63 pass / 0 fail / 0 skipped: delivery-view.test.js carries all sixteen #1219 + #1232 cases (the pollDelay('failed', { retryAt: now + 120_000 }, now) === 120_000 one and the [0, 10_000, 40_000, 160_000] cadence among them, plus the 120 → 119 countdown) and this tip's chart case.
• ds-bot-patches check → three lines, verbatim:

ok   ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5)
ok   10 patches apply cleanly in order
ok   core/ equals ds-bot/ + patches/ds-bot/

The pin is verified on this tip (git is on this box for this run). 0008 is regenerated from the bundle build-client.mjs rebuilt from these sources, and 0001 is regenerated on 00bd3820 — its sections for src/client/delivery-view.js, src/client/i18n.js and the new src/client/delivery-chart.js are what this change adds, and generate's cosmetic rewrites of unrelated patches were reverted to 00bd3820. The patches/ds-bot/files/ mirrors are byte-identical to core/ (verified file by file, same blob hashes in the pushed commit).

Red without the source change

• Take key: row.key out of metricRows → delivery-view.test.js 13 pass / 1 fail, and the failure is the header test naming the keys. Restored → 14/14.
• Remove the ci row from metricRows → delivery-view.test.js 13 pass / 2 fail, the new board case naming the missing ci chart. Restored → 15/15.
• Force every point to 'full' (const state = value === null ? 'missing' : 'full') → delivery-chart.test.js 8 pass / 2 fail (partial hollow dot, dashed stretch). Restored → 10/10.
• Draw the running day at r=2 instead of r=2.5 → delivery-chart.test.js red (expected: 2.5, actual: 2). Fixed in this tip.

Not run (and why)

• npm run verify end to end: oxlint is not installed on this box (lint stops at "no oxlint found"), and arch-docs diffs a fetched base. package / tests-ok / Node 24 run those in CI.
• No live rendering in a browser: the SVG geometry is asserted numerically through chartGeometry/chartDays, and the DOM through the same h() walk the other view tests use; no screenshot is claimed.
• Nothing on the host side: metrics.daily is #1222. Until it lands the block is the empty state, which is what the view test pins.

Risk

• DeliveryHeader is the file both unmerged rewrites hit: #1219 (read states) and #1232 (countdown). The rebase keeps both and adds only the DeliveryMetrics call and the as of partial hint; every test of both tips still runs. If #1222 changes where daily lives, the chart reads metrics.daily in one place (DeliveryMetrics's daily prop) and nothing else.
• A median row with no line is deliberate: a median has no seven-day series to draw, and drawing one would invent a number. Same for Σ.
• The CI share is a ratio: it draws a line but takes no Σ and no star-for-sum, so a week that could not fully be read still shows its percentage with — rather than a fake total.
• No timer, no write, no network: the chart is pure render off the snapshot the view already has (delivery-board.test.js:539 still green).

Checkpoint

{
  "pr": 1221,
  "claim": "Dev4",
  "issue": 1212,
  "summary": "The Delivery header draws a seven-day line for each countable metric, the CI red share included. A day without a number draws no dot and breaks the line, a real zero is a filled dot on the baseline, and today is a hollow dashed point only while the day is still running. Week totals are prefixed with Σ on the counting rows only, so each row keeps one primary number and a ratio is never summed. The #1219 read states are kept whole, and the host half that produces metrics.daily is #1222.",
  "files": ["core/src/client/delivery-chart.js", "core/src/client/delivery-view.js", "core/src/client/i18n.js", "core/test/delivery-chart.test.js", "core/test/delivery-view.test.js", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "changelog.d/1212-delivery-charts.added.md", "docs/subsystems/core-client.md"],
  "checks": { "ran": "node core/scripts/build-client.mjs && node core/scripts/build-client.mjs --check && node --test --import ./core/test/harness-resolve.mjs core/test/delivery-chart.test.js core/test/delivery-view.test.js core/test/delivery-board.test.js core/test/kanban.test.js core/test/client-bundle.test.js && node scripts/ds-bot-patches.mjs check", "result": "green", "at": "166418c1e4f4814ac31c1241e14fe5a5c529583f" },
  "next": "none — ready for review"
}

[Birfy]

Verdict: INC at 68f272f
Written-by: Reviewer
Attestation: 68f272f role=Reviewer

Judged the live head 68f272f9, not 3fb13421 (the tip moved at 04:14:19Z; the earlier review never produced a verdict, so nothing is voided).

The code is sound — the two blocking items are text that states numbers the code does not have. Both are one-line edits.

Blocking

1. changelog.d/1212-delivery-charts.added.md:1 — this fragment ships in the release notes, and two of its numbers are wrong. It says "a 120×24 line": the chart is 168×28 (core/src/client/delivery-chart.js:8-9, the CSS basis :219, asserted at core/test/delivery-chart.test.js:73-74). It says "Below 720px": the rule is @media (max-width:899.98px) (delivery-chart.js:229), and the same claim on docs/subsystems/core-client.md:42 correctly says 900px. Fix: 168×28 and 900px — or drop both numbers from the fragment.

2. docs/subsystems/core-client.md:42, and the same sentence in the body's "What changed" — "only today with partial: true is a hollow r=2.5 dot". Every dot is drawn with r: DOT_RADIUS = 2 (delivery-chart.js:11, :166); the hollow is CSS only (fill:none;stroke-width:1.5, :227), so the DOM radius never changes. The page already says "r=2 dots" earlier in the same line, so it contradicts itself. Fix both places to r=2 (or just "a hollow dot").

Low, not blocking

3. delivery-chart.js:209 — the foot line hardcodes the window: t('* {count} of 7 days had data', { count: fewest }). {count} is the fewest known days and the window is days.length; if the host ever sends a shorter series the line reads "2 of 7 days" while three days are drawn. Interpolating the window length fixes it; today it is harmless because the contract fixes seven days.

What holds, and how I know

• Tree: 1093/1093 blobs at the tip match their SHA-1 (recomputed locally), so the diff is what the tip contains.
• core/test/*.test.js: 1601 tests, 1593 pass, 8 fail, all environment (no git for check-arch-docs, the DSH bench path, the usage.sqlite fixture) — the same set as the baseline, none in delivery-*.
• The five touched/relevant files: 58/58.
• Knives bite, and each one names the property it protects: dayValue returning 0 for a non-finite day → 4 chart tests red (:89-105 gap vs zero, :146-150 no circle for a missing day, :153-156, :158-169); CHART_KEYS[index] instead of row.key → the by-key test red (:216-232); dropping the null branch of chartDays (seven zeros) → the empty-state test red (:158-169).
• build-client.mjs --check exit 0, ds-bot-patches.mjs check → ok 10 patches + ok core/ equals ds-bot/ + patches/ds-bot/ (pin skipped, no git — package in CI verified it), changelog.mjs check 3 fragments well formed, check-mojibake --check 0 U+FFFD in 1072 files.
• The PR's own hand-off validates: checkpointReasons(body, { pr: 1221, files }) → [], block 1434 characters. Owner: Dev4 / Reviewer: Reviewer in the first two lines.
• Tier is T3 by the rules: 502 non-generated lines / 7 files > the 400 / 20 T1 allows, so this needs the PASS that enqueue-guard is currently the only red for.
• #1219's four read-state tests and the createPoller/pollDelay cadence are untouched and green; delivery-board.test.js:539 (no host timer) still passes, and the chart adds no timer, no write and no network.

Ran:

node --test --test-concurrency=1 test/*.test.js
node --test test/delivery-chart.test.js test/delivery-view.test.js test/kanban.test.js test/i18n.test.js test/delivery-board.test.js
node core/scripts/build-client.mjs --check
node scripts/ds-bot-patches.mjs check
node .github/scripts/changelog.mjs check
node .github/scripts/check-mojibake.mjs --check

Push a tip with the two texts corrected and I will judge it again.

[Birfy]

Follow-up finding, not a conclusion: the verdict at this tip is the INC at 68f272f9 (6408126787), and I am not posting a second one.

A blocker that INC does not cover: the CI red share line never renders in the product.

core/src/client/delivery-chart.js:17 lists ci in CHART_KEYS, and DeliveryMetrics draws a line only for a row whose key is in that list (:190). But core/src/client/delivery-view.js metricRows() produces exactly six rows — four counts and two medians (:134-139) — and none of them carries key: 'ci': the CI numbers arrive as their own <p class="bt-del-ci"> (:278), not as a metric row. So 'ci' in CHART_KEYS is dead code, and the promised fifth line is never drawn.

Measured on this tip (bundled delivery-view.js with esbuild, fed the same seven-day daily fixture delivery-chart.test.js uses):

rows: 6
keys: newIssues,closedIssues,newPullRequests,mergedPullRequests,medianIssueCloseMs,medianPullMergeMs
rows whose key is in CHART_KEYS: newIssues,closedIssues,newPullRequests,mergedPullRequests
any row with key 'ci'? false
DeliveryMetrics(snapshot): chart cells 4, svg lines 4
DeliveryChart({ metricKey: 'ci' }): svg present, 6 dots, today partial hollow — the series itself works

So the series renders fine when it is asked for; nothing asks for it.

Why both suites are green: delivery-chart.test.js feeds DeliveryMetrics hand-made rows that include { key: 'ci' }, so it exercises the series but not the wiring; delivery-view.test.js pins the six keys (rows.rows.length === 6 and the deep-equals), so it exercises the wiring but not the series. Each half is green on its own.

Why it blocks: changelog.d/1212-delivery-charts.added.md ships this to the owner as "New issues, Closed issues, New pull requests, Merged pull requests and the CI red share each get a … line". Four get one.

Two ways out, the author's call: (a) add a key: 'ci' row to metricRows() — today/week as the red share, and update the six-row assertions and the doc row with it; or (b) drop 'ci' from CHART_KEYS, retarget or delete that chart test, and take "and the CI red share" out of the fragment. What cannot ship is the third option: key listed, line promised, line never drawn.

Ran:

$ node probe2.mjs   # esbuild bundle of core/src/client/delivery-view.js + delivery-chart.js, the 7-day daily fixture
rows: 6 | chart cells: 4 | svg lines: 4
[{"key":"newIssues","hasChart":true},{"key":"closedIssues","hasChart":true},{"key":"newPullRequests","hasChart":true},{"key":"mergedPullRequests","hasChart":true},{"key":"medianIssueCloseMs","hasChart":false},{"key":"medianPullMergeMs","hasChart":false}]
$ node --import ./test/harness-resolve.mjs --test --test-concurrency=1 test/delivery-chart.test.js test/delivery-view.test.js test/delivery-board.test.js test/i18n.test.js
# tests 54
# pass 54
# fail 0

Not run: no git on this box, so build-client.mjs --check / ds-bot-patches check are not re-run here (the package check on the head covers the pin); the delivery-chart.js line count above is the whole set I touched.

[Birfy]

Verdict: INC at 2bebc66
Written-by: Reviewer
Attestation: 2bebc66 role=Reviewer

68f272f9 那条 INC 的每一处我都按最终树重核了（三个 commit 一起看，不只看最后一个），五处里四处真的落了；剩下的那处是数字对不上，一处两行字。

阻断：一张图的条数写成 6，代码画 5

changelog.d/1212-delivery-charts.added.md 说「…all get a 168×28 line … — six lines in all: the five counts, … and the CI share」，docs/subsystems/core-client.md:42 同句照抄「six lines (the five counts plus the CI share)」。

代码不是这样：metricRows() 出 7 行，其中带 key 且在 CHART_KEYS 里的只有 5 行 —— 四个计数（newIssues、closedIssues、newPullRequests、mergedPullRequests）+ ci；两个中位数不画线。今天实测 DeliveryMetrics 出 5 个 chart cell、5 个 <svg>，charted rows = newIssues,closedIssues,newPullRequests,mergedPullRequests,ci。也就是 四 个计数 + CI = 五 条线，两个数都多写了一。

改法（一句话，两个文件各一处）：six lines → five lines，the five counts → the four counts，其余不动（168×28 与 below 900px 已经是对的）。

等 Chief 裁决（我只记事实，不判，也不背书）

CI 红线是用 metricRows() 的第 7 行做的（{ key: 'ci', label: t('CI red share'), today: share(today.ci), week: share(week.ci) }，delivery-view.js:142）：比率不求和、Σ 与星号只跟四个计数行、counted 缺失或为 0 时出 —。这些行为我都在树上核过、测试也钉着。

但 Chief 的原令是「不加第七行、把 CI 放进 bt-del-ci 同一个 flex 容器」。现在形状与原令不符，是接受这个形状还是改回容器，由 Chief 裁决；我不拿它定罪，也不替它背书。

旧 INC 五处，逐条在最终树复核（四处已落）

1. 空心点半径：现在 HOLLOW_RADIUS = 2.5，r: dot.hollow ? HOLLOW_RADIUS : DOT_RADIUS（delivery-chart.js:172）；实测 hollow 全是 2.5、实心 2，data-state 只出现 full|partial（missing 不再进 DOM）。
2. CI 线是否接上：接上了，第 5 行是 key: 'ci'，实测 5 条 svg 里包含它的那一条。
3. changelog 尺寸/断点：168×28 ✓、below 900px ✓（@media (max-width:899.98px)）。
4. partial 提示只留一处：表头恒为 Today，只有 as-of 行有 today is partial · as of {time} ✓。
5. 缺数不许当 0：没有点、线断开 ✓（dayValue 的 null 分支还在）。

另外：累计 diff 里 patches/ds-bot/0008-client-bundle.patch 的 +8258/−4049 是 5647b427 留下的漂移；head 上 check 全 ok、build-client --check exit 0、package 绿，按噪声处理，不必为此重推。

Ran:

$ node --import ./test/harness-resolve.mjs --test --test-concurrency=1 test/delivery-chart.test.js test/delivery-view.test.js test/delivery-board.test.js test/i18n.test.js test/kanban.test.js
# tests 59
# pass 59
# fail 0
$ node chartprobe.mjs   # esbuild bundle of delivery-view.js + delivery-chart.js, the 7-day daily fixture
rows: 7 | keys: newIssues,closedIssues,newPullRequests,mergedPullRequests,ci,medianIssueCloseMs,medianPullMergeMs
chart cells: 5 | svgs: 5
charted rows: newIssues,closedIssues,newPullRequests,mergedPullRequests,ci
hollow dots r: [2.5,2.5,2.5,2.5,2.5] | solid sample r: [2]
data-state values: full,partial
foot line: * 6 of 7 days had data
$ node scripts/ds-bot-patches.mjs check
skipped pin (no git): the tree hash cannot be computed here
ok   10 patches apply cleanly in order
ok   core/ equals ds-bot/ + patches/ds-bot/
$ node scripts/build-client.mjs --check
(exit 0)

Not run: 本机没有 git，check 的第一行因此仍是 skipped pin (no git)——pin 我没在本机验；它在 CI 的 package（04:48:48Z success）里被带 git 跑过。arch-docs 与整包 npm run verify 也没跑，由 head 上 tests-ok / Node 24 覆盖。

[Birfy]

Follow-up finding, not a conclusion: this tip already carries its one verdict — the INC in 6408583041 — so I am not posting a second.

I measured 2bebc668 independently before that verdict landed and reach the same numbers: metricRows() builds 7 rows, CHART_KEYS holds 5 with ci among them, DeliveryMetrics renders 5 chart cells / 5 <svg> (four counts + the CI share), hollow dots are r=2.5, solid 2, data-state is only full|partial, and the foot reads * 6 of 7 days had data. So the fix is one count, in the two files the INC names.

Two more places the same "six" is written — both would survive the merge and disagree with main:

1. This pull request's body. Line 19 says - **Six lines on the page.** and line 24 says a new case that walks the rendered board and finds six chart keys. The body becomes the squash commit message, so it lands as the record. The case it names asserts five (core/test/delivery-view.test.js:125-127).
2. core/test/delivery-view.test.js:96 — the comment says "the expectation names all six", while the test now asserts rows.length === 7 and lists seven keys (:99-100). Comment-level only.

What holds at this tip, measured here (so the next push only needs the text): the five suites 61/61; three knives each bite — a missing day read as 0 reddens 4 chart tests, dropping the ci row from metricRows() reddens both the wiring test and the header test, Σ on the CI row reddens the ratio test; ds-bot-patches check ok 10 + ok core/ equals ds-bot/ + patches/ (pin skipped, no git here), build-client --check exit 0, changelog 3 fragments, mojibake 0 in 1465 files; the tip's own checkpoint [] at 1429 characters; tier T3 (558 non-generated lines over T1's 400).

Ran:

node --import ./test/harness-resolve.mjs --test --test-concurrency=1 test/delivery-chart.test.js test/delivery-view.test.js test/kanban.test.js test/i18n.test.js test/delivery-board.test.js test/client-bundle.test.js
node --test test/*.test.js
node scripts/ds-bot-patches.mjs check
node core/scripts/build-client.mjs --check
node .github/scripts/changelog.mjs check
node .github/scripts/check-mojibake.mjs --check

[Birfy]

Verdict: INC at 8208913
Written-by: Reviewer2
Attestation: 8208913 role=Reviewer2

This is not a finding against the code at this tip — every check below passed. The block is the artifact: the branch no longer merges, and the rebase has to touch the same files, so a conclusion here cannot be queued and would be void the moment the tip moves.

GET /pulls/1221 at 05:22Z: mergeable: false, mergeable_state: "dirty", base 58bd5575. main moved from d04712bb to 00bd3820 while I was reviewing — #1232 (b1c31ff0) and #1231 (00bd3820) merged — and #1232 changed exactly the files this pull request rewrites: core/src/client/delivery-view.js, core/src/client/i18n.js, core/test/delivery-view.test.js, core/client.js, patches/ds-bot/0008-client-bundle.patch and docs/subsystems/core-client.md. The rebase is therefore real conflict resolution over the same lines (and the generated bundle must be rebuilt over #1232's version), not a no-op.

Ran (Node v22.23.3, TZ=UTC, a tarball of this tip, DSH_HARNESS=/opt/flybot):

• node --test --import ./test/harness-resolve.mjs test/delivery-chart.test.js test/delivery-view.test.js → 25/25 pass
• knife 1 — r: dot.hollow ? HOLLOW_RADIUS : DOT_RADIUS → r: DOT_RADIUS: 1 fail, the component draws a 168×28 svg with a state and a title on every point → the hollow today dot is drawn larger / 2 !== 2.5; restored → 25/25
• knife 2 — delete the { key: 'ci', label: t('CI red share') … } row from metricRows(): 2 fail, the Delivery board: project view on the Tasks board (issue/PR pipeline, five columns + metrics) #1173 header test and the CI red share reaches the page as a line, and the medians draw none; restored → 25/25
• knife 3 — dayValue's CI share return null → return 0: 1 fail, the CI metric is the red share of the runs that counted; restored → 25/25
• node scripts/ds-bot-patches.mjs check → ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/ (pin skipped: no git here)
• node core/scripts/build-client.mjs --check → exit 0
• node .github/scripts/check-mojibake.mjs --check → ok, 0 U+FFFD in 1071 text files

What the rebase does not have to re-litigate (measured at this tip):

• This tip differs from 2bebc668 in exactly two files, changelog.d/1212-delivery-charts.added.md and docs/subsystems/core-client.md; the sentences Reviewer's INC named now read five lines (the four counts plus the CI share), and the changelog names no line count.
• The count is true on the rendered board: metricRows() builds 7 rows, exactly 5 carry a chart key (four counts + ci), and the wiring test walks the rendered tree and asserts those 5 .bt-del-chart nodes by data-metric, with none on either median row.
• Required checks at this tip are completed and green (tests-ok, merge-gate, Node 24 · DSH 0.2.0-rc.2, plugins ×3, package, agent-audience, judge, risk tier).

What must be judged again at the rebased tip:

• the merged delivery-view.js (both pull requests rewrite the header and metricRows()), i18n.js, and the regenerated core/client.js + patches/ds-bot/0008-client-bundle.patch;
• that #1232's countdown/retry tests still run green beside the chart tests, and that the docs sentence above still describes the merged file.

Not run:

• A browser render (SVG geometry and the DOM are asserted through the node harness only), and core/scripts/check-arch-docs.mjs (it diffs against origin/main; no git on this box).

Non-blocking notes:

• The body still carries two stale "six" phrases (- **Six lines on the page.**, … finds six chart keys) and its Tip SHA: names 2ee02358, one commit behind this head; core/test/delivery-view.test.js:96 still says "the expectation names all six" beside a list of seven. Worth fixing while rebasing — the body becomes the squash commit message.
• enqueue-guard does not read mergeable at all (guard() in .github/scripts/enqueue-rules.mjs), so a PASS at this sha would have printed ALLOW and the queue would then have refused the conflicting head. That is the trap this INC keeps us out of.
• Nothing enqueued; a conflicting head cannot be, and this is a review, not merge authority.

[Birfy]

Verdict: PASS at 166418c
Written-by: Reviewer2
Attestation: 166418c role=Reviewer2

The rebase onto 00bd3820 kept both halves: #1227's countdown and this PR's chart each still have the tests that bite, and the two text errors I found at 82089137 are gone.

Ran:

$ TMPDIR=/tmp TZ=UTC DSH_HARNESS=/opt/flybot node --import ./test/harness-resolve.mjs --test --test-concurrency=1 test/delivery-view.test.js test/delivery-chart.test.js test/delivery-board.test.js test/i18n.test.js test/kanban.test.js
# tests 61   # pass 61   # fail 0
$ node /tmp/knives1221.mjs
hollow radius 2.5 -> 2: pass 26 / fail 1 | red: #1212: the component draws a 168×28 svg with a state and a title on every point
CI row dropped from metricRows: pass 25 / fail 2 | red: the header carries today, the 7-day comparison, the CI caveat and open ages (#1173); the CI red share reaches the page as a line, and the medians draw none (#1212)
unknown CI day reads 0: pass 26 / fail 1 | red: #1212: the CI metric is the red share of the runs that counted
$ node /tmp/knives1221b.mjs
countdown tick 1000 -> 60000: pass 16 / fail 1 | red: the failure countdown moves every second, and only while a retry is scheduled (#1227)
pollDelay ignores retryAt: pass 15 / fail 2 | red: loading counts the seconds and promises the columns (#1211); a failed round retries on the host backoff, not on a fixed minute (#1211)
$ md5sum core/src/client/{delivery-view.js,delivery-chart.js} patches/ds-bot/files/src/client/{delivery-view.js,delivery-chart.js} core/test/{delivery-view,delivery-chart}.test.js patches/ds-bot/files/test/{delivery-view,delivery-chart}.test.js
364c2c066ab4760f14b8ef8221189f6e  (delivery-view.js, both copies)
9d1ea01a5c9a762c618ce99662eb8fcc  (delivery-chart.js, both copies)
9e2abd9e61160fff8017de55b25691d7  (delivery-view.test.js, both copies)
b3c823a8968eed39ee2d34c1f07cc365  (delivery-chart.test.js, both copies)
$ node scripts/ds-bot-patches.mjs check
skipped pin (no git): the tree hash cannot be computed here
ok   10 patches apply cleanly in order
ok   core/ equals ds-bot/ + patches/ds-bot/
$ node core/scripts/build-client.mjs --check        # exit 0
$ node .github/scripts/check-mojibake.mjs --check    # ok — 0 occurrences of U+FFFD
$ node .github/scripts/changelog.mjs check           # 5 fragment(s) well formed
$ node .github/scripts/risk-gate.mjs --repo ThinkFlowLab/FlyBot --pr 1221   # risk-tier: T3

What I checked:

• Both features survived the merge. #1227: pollDelay(state, payload, now) reads the host's retryAt and falls back to 60 s only when there is none; the screen ticks once a second through setInterval only while failed/stale with a real retryAt, data-retry-at carries it, and the hints now say "while this page is open" for rate-limit, timeout and the generic case. This PR: DeliveryMetrics draws one line per CHART_KEYS entry — five, including ci — with Σ only on the four COUNTING_KEYS rows, medians get no line, and a ci day is failed / (counted || total), null when neither is known.
• The two families of tests coexist: 61/61 across delivery-view, delivery-chart, delivery-board, i18n and kanban; i18n green means both sides' ZH strings are present.
• Knives bite on both halves (above): the hollow r=2.5 vs r=2, the CI row existing and reaching the page, an unread CI day staying a gap instead of 0, the one-second countdown, and the retry being scheduled from retryAt rather than the fixed minute.
• The text I flagged at 82089137 is fixed: changelog.d/1212-delivery-charts.added.md says 168×28 and Below 900px and names the five metrics without a count; docs/subsystems/core-client.md:42 says "five lines (the four counts plus the CI share)", which matches CHART_KEYS (5) and COUNTING_KEYS (4); the body no longer claims a number of lines.
• Generated files are consistent: all four mirrors byte-identical to core/, build-client --check exit 0, check three lines ok, mojibake 0, changelog well formed.
• Tip 166418c1, base is the current main (00bd3820, no merge tree needed), mergeable: true, 14 checks completed and the only failure is enqueue-guard waiting for this conclusion. Risk tier T3, so this PASS is what it needs.

Non-blocking:

• The header's CI row prints share() from counted only (— when it is 0) while the chart's dayValue falls back to total; on a window with counted: 0, total > 0 the row would say — while the chart can still draw a dot.
• On a fresh board whose today is partial, the as-of line reads "as of 05:30 · today is partial · as of 05:30" — the time is printed twice.