[HugoXK]

chore(workflow): remove the dead workflow/say surface (#1475)

Fixes #1475
Owner: Chief
Reviewer: Reviewer
Written-by: Dev-2

Base: 6202359
Tip: 510ccfb (the fork head; its tree is fd6f410b6f96f94691abaddb18b398aec1afb2e7, the tree every check below ran on)
Tree: fd6f410b6f96f94691abaddb18b398aec1afb2e7

Base note: the reviewed tree was cut on 1b6f588c; live main has since moved 20 commits to 620235991e46c24836d03b16b76d642c9f7a4aa1, and this branch was rebased onto it once (no further rebases). The only conflict was docs/subsystems/workflow.md — main had rewritten the same endpoint sentence (the maxConcurrent control, workflow/rename, workflow/delete); it is kept in full with workflow/say dropped from the list. plugins/workflow/README.md, index.js and src/service.js auto-merged: the diff against live main is still exactly the four deletions plus the three test-harness files (9 files, +154/−30).

What changed

workflow/say was a host command with a handler and no caller, and its only behavior was to write a fabricated receipt into the workflow chat. The surface is gone, in four places:

1. plugins/workflow/index.js — the workflow/say handler registration.
2. plugins/workflow/src/service.js — say() (15 lines), including the fabricated { kind: 'bot', … 收到。我继续处理「…」 } message.
3. docs/subsystems/workflow.md — the workflow/say token; the other nine write commands are unchanged.
4. plugins/workflow/README.md — the bare say token (the issue author added this line to chore(workflow): remove the dead workflow/say surface and its fake receipt #1475's In scope at 2026-10-27T15:54:59Z).

Nothing else moves: stageMessages() and its filtering, plugins/workflow/client.js, the stored workflows and the remaining endpoints stay as they were; there is no migration and historical records are untouched.

Three changes outside the four deletions, needed so the acceptance assertion runs against a real host instead of a unit mock:

• plugins/workflow/package.json: the test script gains --import ./test/resolve.mjs.
• plugins/workflow/test/resolve.mjs (new): module resolution copied from plugins/tree/test/resolve.mjs — three lines adapted (the @flybot/tree comment and the error string). ds-bot resolves to the repo-root core/ (or FLYBOT_CORE), and @deepseek-ai/* from inside it to a DSH checkout (DSH_HARNESS or <core>/dev/harness).
• plugins/workflow/test/fake-cordis.js (new): a minimal Cordis-like context, copied verbatim from plugins/tree/test/fake-cordis.js except its first comment line.

The package's files list is unchanged, so test/ is not shipped; .github/scripts/check-pack.mjs and plugin-imports.test.mjs pack and import exactly that list. CI already sets DSH_HARNESS (${{ github.workspace }}/core/dev/harness in .github/actions/flybot-tests/action.yml) and still runs npm test in plugins/workflow — the flag only changes what that script loads. Run without a core or harness locally and resolve.mjs throws @flybot/workflow tests: no FlyBot core at … (set FLYBOT_CORE): a prerequisite of the test, not a regression of anything shipped.

The acceptance shape

Deleting say() is dead-code removal; the acceptance point is the endpoint's shape, not the method, and there is no test for the method itself. plugins/workflow/test/host.test.js boots the real host (ds-bot's public entry in the fake Cordis context, ctx.plugin(workflow, { persist: false })) and asserts both halves:

• flybot/workflow/state answers { ok: true, … } — the plugin is loaded, so the next answer cannot be "no plugin registered";
• flybot/workflow/say answers { ok: false, error: { code: 'bot/not-found', message: 'Unknown FlyBot endpoint workflow/say', details: {} } } — the route strips flybot/ (core/src/host/channel.js) and the dispatcher throws that message and code (core/src/host/hooks.js). Not { ok: true }, not {}, not undefined.

workflow/say and 收到。我继续处理 have no hits left in plugins/ product code, core/, docs/ or the client bundle. The only remaining occurrences are inside the two tests that assert the name is gone (assign.test.js registration list, host.test.js host answer): a test that pins an absence has to name what is absent, so "zero hits" cannot hold for the test files themselves, and this pull request does not claim it does.

No changelog fragment: unreachable surface removal.

Verification at the tip

Tip SHA: 510ccfb
All numbers were measured on this pull request's tree fd6f410b6f96f94691abaddb18b398aec1afb2e7:

• TZ=UTC ARCH_DOCS_BASE=620235991e46c24836d03b16b76d642c9f7a4aa1 npm run verify — exit 0: core 1866, social 527, tree 125, timeline 125, workflow 106, .github 548, interop 37, live-e2e 24; oxlint 0 errors (only the repository's existing warnings: 63/36/9/2/7/0); build-client --check clean; arch-docs: OK (9 changed file(s)); ds-bot-patches check: ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5) and ok 10 patches apply cleanly in order; node .github/scripts/changelog.mjs check: 56 fragment(s) … are well formed.
• npm --prefix plugins/workflow test on this tree — 106 tests, 106 pass, 0 fail.
• The same suite on live base 62023599, unchanged — 105 tests, 105 pass, 0 fail.
• Graft: only this pull request's test files and package.json on live base 62023599, product code untouched — 106 tests, 104 pass, 2 fail: assign.test.js apply registers the workflow endpoints and stays quiet when disabled (the registration list still carries workflow/say) and host.test.js workflow plugin on the real host: the removed say endpoint is unknown, not an empty answer (the real host answers { ok: true, … }).
• Earlier numbers (before the rebase) were measured on tree 19aa2e88… against 1b6f588c; the tree moved, so every number above was measured again rather than carried over.

Not run: no live instance (no instance access), no browser beyond the test harness; CI was not waited on.

Checkpoint

{
  "pr": 1497,
  "claim": "Chief",
  "issue": 1475,
  "summary": "The `workflow/say` host command is gone: its handler registration, the `say()` method that fabricated a 收到。我继续处理 receipt in the workflow chat, and its two documentation tokens. `stageMessages()`, the client, the stored workflows and the other endpoints are untouched, and no migration runs. A real-host test pins the outcome: `flybot/workflow/state` still answers `{ok:true}`, while `flybot/workflow/say` now answers `{ok:false,error:{code:'bot/not-found'}}`. A resolve hook, a fake Cordis context and an `--import` let that assertion run; the package ships no tests.",
  "files": ["plugins/workflow/src/service.js", "plugins/workflow/index.js", "plugins/workflow/test/host.test.js", "plugins/workflow/test/assign.test.js", "plugins/workflow/test/resolve.mjs", "plugins/workflow/test/fake-cordis.js", "plugins/workflow/package.json", "docs/subsystems/workflow.md", "plugins/workflow/README.md"],
  "checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=620235991e46 npm run verify, exit 0 (core 1866, social 527, tree 125, timeline 125, workflow 106, .github 548, interop 37, live-e2e 24, oxlint 0, arch-docs OK 9, changelog ok) on tree fd6f410b; workflow suite at base 62023599 105/105; graft 104/106, 2 red", "result": "green", "at": "510ccfb23c16091be8fdb9652e801799814c7cbf" },
  "next": "none — ready for review"
}

[HugoXK]

@Birfy tests-ok is green at 553aebd6663b and this PR has no review yet. Could you review this tip?

[HugoXK]

@Birfy review request — PR #1497 at 510ccfb23c16091be8fdb9652e801799814c7cbf.
Please produce a Reviewer Verdict at this tip.

[Birfy]

Written-by: Rework — agent-pr added (bot-authored pull request; the guard's fork exemption is unchanged).

Rework check at 510ccfb (tree fd6f410): a fresh replay of the reviewed 9-file change set onto live main 6202359 is byte-identical to this tip, and the tree diff against main is exactly the 9 files, +154/−30. plugins/workflow on this tree: 106 tests, 106 pass. With the two product deletions reverted and the tests kept: 104/106 — assign.test.js (registration list) and host.test.js (real host answer) fail, which is the red first. No workflow/say or 收到。我继续处理 left outside those two tests. No new commit: the tip above is the one to review.

[Birfy]

Verdict: PASS at 510ccfb
Written-by: Reviewer
Attestation: 510ccfb role=Reviewer

Ran at this tip (2026-10-28T05:35Z) — tree unpacked from the fork head, 1261 blobs byte-identical to fd6f410b6f96… (the tree this tip's CI ran on), base 62023599:

$ cd vfy1497 && node treecheck.mjs
tree status 200 truncated false entries 1357
tracked 1261 local 1261 missing 0 diff 0 extra 0

$ cd vfy1497/tip && npm --prefix plugins/workflow test
# tests 106 / # pass 106 / # fail 0

$ cd vfy1497/base && npm --prefix plugins/workflow test          # live base 62023599, unchanged
# tests 105 / # pass 105 / # fail 0

$ # red-first: only the two product files back to base (index.js registration + service.js say()), this PR's tests kept
$ cp ../base/plugins/workflow/index.js plugins/workflow/index.js && cp ../base/plugins/workflow/src/service.js plugins/workflow/src/service.js
$ npm --prefix plugins/workflow test
not ok 10 - apply registers the workflow endpoints and stays quiet when disabled
not ok 88 - workflow plugin on the real host: the removed say endpoint is unknown, not an empty answer
# tests 106 / # pass 104 / # fail 2

$ grep -rn --exclude-dir=node_modules --exclude-dir=ds-bot "workflow/say" .
./plugins/workflow/test/assign.test.js:291 …
./plugins/workflow/test/host.test.js:2,3,5,53,55 …
$ grep -rn "收到。我继续处理" .            # no output
$ grep -rn "\.say(" plugins core/src docs   # no output
$ grep -n "say" plugins/workflow/client.js  # no output

$ # merge tree: current main fbe88a2 (#1535, landed 05:24Z) + this PR, 3-way on the three overlapping files
$ diff3 -m tip/docs/subsystems/workflow.md base main  → exit 0, 0 conflicts, no say
$ diff3 -m tip/plugins/workflow/README.md …           → exit 0, 0 conflicts, no say
$ diff3 -m tip/plugins/workflow/index.js …            → exit 0, 0 conflicts, no say; main's `tools: spec.tools` kept
$ npm --prefix plugins/workflow test                  # run on that merge tree
# tests 107 / # pass 107 / # fail 0

Not run: no smoke bench, no live DSH instance and no browser (this change touches neither host nor client); no local npm run verify — CI ran it on this tip.

审查要点：

• 删除面与 chore(workflow): remove the dead workflow/say surface and its fake receipt #1475 的「delete exactly these」一一对应：index.js 注册行、service.js 的 say()（含伪造的 收到。我继续处理）、docs/subsystems/workflow.md 的 token、README.md:78 的 say；stageMessages()、client、存储与其余端点未动，9 文件 = 4 处删除 + 5 个测试/脚本文件。
• 无残留调用点与死导出：全树 workflow/say 只出现在两个「断言它不存在」的测试里；.say(、收到。我继续处理、client.js 里的 say 零命中；say() 用过的 cleanLine / displayRun / orderedIds / nodeById / now / push 仍有多处调用，没有留下未用导入或常量（CI oxlint 0 error）。
• 红先成立且不是空转：只回退两个产品文件、保留本 PR 测试 → 106 里恰好 2 条红，正是注册表与真机答复两条断言；tip 106/106、base 105/105、合并树 107/107。
• 真机钉子有意义：host.test.js 用 apply() 起真 host，先断言 state.ok 且 value.workflows 非空（插件确实加载），再断言 flybot/workflow/say 回 bot/not-found 的 Unknown FlyBot endpoint workflow/say，不是 {ok:true} 也不是空对象；resolve.mjs / fake-cordis.js 与 plugins/tree/test/ 同名文件只差注释与包名三行，package.json 的 files 未含 test/，不随包发布。
• 合并面：本 tip 切开后 main 又进了 fix(workflow): a node's tools selects connectors instead of granting everything #1535（fbe88a2，05:24Z），两者在 workflow.md / README.md / index.js 三个文件上重叠；3-way 干净、main 的 tools: spec.tools 保留、say 仍为零，所以入队后 merge tree 上再跑不会撞。
• CI（本 tip）：除 enqueue-guard 外全终态且绿（tests-ok、Node 24、package、四个插件、merge-gate、judge、risk-tier）；enqueue-guard 的红只有一句 no Verifier report names the tip 510ccfb23c16，这条 PASS 就是缺的那份报告。agent-pr 已在，正文 Tip: = head 510ccfb，checkpoint 有效，六栏齐（Reproduce 用 acceptance shape、Red 用 graft、Risk 用「只删不迁、test/ 不发布」给出）。非阻塞观察：resolve.mjs / fake-cordis.js 是从 plugins/tree 复制的第二份胶水，将来可抽共享文件，不属本 PR 整改项。