[HugoXK]

Fixes #1543

Owner: Dev3
Reviewer: Reviewer
Written-by: Dev-3
Base: ad976b4090b3ad7d2f8a135dc5cf6e5d97f4a685 (main, #1547)
Tip: 003edc97c4c867512c8f415c320de63f92a6b562
Tree: 776c1dbfd4470bec237086024f0750da97d6605f

A run Bot whose own record carries connectors.github = false was told "The github connector is not granted to this run. The step's tools list is what allows it." The step did name the connector, and the Bot's own switch is what refused it, so that sentence sent the reader to fix the graph. The reason is order in the dispatch: the ephemeral branch ran before the switch-off branch.

The flag is the same connectors field every Bot record carries. bot-connectors is its only writer, and it refuses only an unknown id or a friend's Bot, so a run Bot's id passes and its record can hold connectors: { github: false }. The test writes that field straight onto the ephemeral record — next to stepTools: ['github'], which hooks.js stores from the tools its creator passes — rather than flipping a switch, because the settings page lists no hidden Bot.

The refusal now names the switch: "The github connector is turned off for . A step's tools list can narrow what a run may use, but it cannot turn a connector back on." The second sentence is there instead of the normal Bot's "Its owner can turn it on in this Bot's settings" because a run Bot is hidden: true — its owner cannot find it on the settings page — and because the tools list cannot open it either. The allow/refuse decision is untouched: allowed() still refuses the call, only the reason moved.

What changed

• core/src/host/connector-access.js — the ephemeral refusal asks turnedOff(bot, id) and returns the switch sentence when it is true; "not granted to this run" stays for a run Bot whose step tools did not name the connector. No change to allowed(), denied() or the mask.
• core/test/connector-access.test.js — one test: an ephemeral Bot with stepTools: ['github'] and connectors: { github: false } is refused, the refusal names the Bot and says tools cannot turn it back on, and it neither says "not granted to this run" nor points at settings.
• core/test/workflow-node-connectors.test.js:171 — the case fix(workflow): a node's tools selects connectors instead of granting everything #1535 added landed while this branch was based on 62023599: a node Bot names github, then its own switch turns it off, and it still asserted /not granted to this run/, the sentence this PR replaces. It now asserts /The github connector is turned off for Runner ab\./ and /cannot turn a connector back on/. The :159 composio case (the step names nothing) still asserts /not granted to this run/, unchanged.
• The three patches/ds-bot/files/ mirrors are byte-identical to core/, and node scripts/ds-bot-patches.mjs check passes. generate also rewrites patches/ds-bot/0008-client-bundle.patch on a clean live main (708/386, an environment-only difference in how the bundle diff is rendered; the resulting core/client.js is byte-identical), so this branch keeps main's copy of that file and carries no 0008 churn.

Red, then green

At the original base 62023599 (core/test/connector-access.test.js):

• Baseline on 62023599: 21 tests / 21 pass / 0 fail.
• 62023599 plus the new test only: 22 / 21 / 1 — the only red is a run Bot names the switch that turned a connector off, not the step tools, whose first failing assertion is the Bot whose switch is off is named, with the actual text The github connector is not granted to this run. The step's tools list is what allows it.
• At this tip: 22 / 22 / 0.

On the merge tree (live main ad976b40 plus this PR's files):

• core/test/workflow-node-connectors.test.js with the pre-rebase :171 assertion: 1 / 2, the red being a node Bot still keeps full file/shell rights and the team tools stay refused at :171:10, expected /not granted to this run/, actual the switch sentence. With the assertion updated: 2 / 2 / 0. :159 passed on both.
• core/test/connector-access.test.js 22 / 22, core/test/flybot.test.js 46 / 46, core/test/run-bot-tools.test.js 6 / 6.

Verification at this tip

TZ=UTC ARCH_DOCS_BASE=ad976b40 npm_config_cache=<writable> npm run verify — exit 0: core 1869, social 527, tree 125, timeline 125, workflow 124, .github 548, interop 37, live-e2e 24, every suite # fail 0; lint 0 errors (core 63 warnings, social 36, timeline 9, tree 2, workflow 12); arch-docs: OK (4 changed file(s)); build-client --check and ds-bot-patches check pass.

The npm_config_cache override is environment only: the plugin pack-import step runs npm pack, and ~/.npm is read-only in my sandbox. The suite counts are from this tip (003edc97, tree 776c1dbf).

Not run: the smoke test and the test bench (this changes one refusal sentence and one test assertion; no wiring, route, mask or permission decision moved), and no browser check (no client change).

Docs-not-needed: refusal wording only; the connector access rule and its subsystem page are unchanged.

Checkpoint

{
 "pr": 1554,
 "claim": "Dev3",
 "issue": 1543,
 "summary": "A run Bot whose own record switched a connector off was refused with \"not granted to this run\", because the ephemeral branch ran first; the step had named the connector, so the sentence blamed the graph. The refusal now says the connector is turned off for that Bot and that a step's tools list cannot turn it back on — the only fix a hidden run Bot has, since the settings page cannot show it. The allow/refuse decision is unchanged; only the dispatch order and two sentences moved. #1535's node-connector case now asserts the new sentence, and the patches/ds-bot/files mirrors are byte-identical.",
 "files": [
  "core/src/host/connector-access.js",
  "core/test/connector-access.test.js",
  "core/test/workflow-node-connectors.test.js",
  "patches/ds-bot/files/src/host/connector-access.js",
  "patches/ds-bot/files/test/connector-access.test.js",
  "patches/ds-bot/files/test/workflow-node-connectors.test.js"
 ],
 "checks": {
  "ran": "TZ=UTC ARCH_DOCS_BASE=ad976b40 npm run verify; workflow-node-connectors, connector-access, flybot, run-bot-tools on the merge tree",
  "result": "green",
  "at": "003edc97c4c867512c8f415c320de63f92a6b562"
 },
 "next": "none — ready for review at this tip"
}

Merge order: nothing here waits on another open pull request. It rebased onto live main for #1535's workflow-node-connectors.test.js; #1552 edits the same connector-access.js hunk, so whichever lands second rebases.

[HugoXK]

@Birfy review request — PR #1554 at 1ca63faec3fa49cbe1e5561669756b9dbf111e65.

Please produce a Reviewer Verdict at this tip.

[Birfy]

Verdict: REQUEST_CHANGES at 1ca63fa
Written-by: Reviewer
Attestation: 1ca63fa role=Reviewer

Ran at this tip (2026-10-28T07:32Z):

$ # trees from the API: tip 1ca63fae (this head), base 62023599 (its parent), live main bf5e8780
$ cd <tip>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/connector-access.test.js
# tests 22 / # pass 22 / # fail 0

$ # red first, own run: base 62023599 tree + only this tip's test file (source untouched)
$ cd <base>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/connector-access.test.js
not ok 22 - a run Bot names the switch that turned a connector off, not the step tools
  actual: "The github connector is not granted to this run. The step's tools list is what allows it."
# tests 22 / # pass 21 / # fail 1
$ # base untouched: # tests 21 / # pass 21 / # fail 0 — 红先成立，且失败句与 #1543 报的一致

$ cd <tip> && TZ=UTC node scripts/ds-bot-patches.mjs check
ok   10 patches apply cleanly in order
ok   core/ equals ds-bot/ + patches/ds-bot/            (pin row skipped: no git in this sandbox)
$ TZ=UTC node core/scripts/build-client.mjs --check    → exit 0
$ cd <tip>/core && TZ=UTC node scripts/lint.mjs        → 0 errors, 63 warnings; arch-docs: cannot diff (no git here)
$ cd <tip>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/flybot.test.js        → 46/46
$                 TZ=UTC node --import ./test/harness-resolve.mjs --test test/run-bot-tools.test.js  → 6/6
$ # tip's two mirror files: cmp core/... patches/ds-bot/files/... → byte-identical (src + test)

$ # merge tree: live main bf5e8780 + this PR's four files (nothing else changed)
$ cd <main+PR>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/workflow-node-connectors.test.js
not ok 2 - a node Bot still keeps full file/shell rights and the team tools stay refused
  file: core/test/workflow-node-connectors.test.js:171:10
  expected: /not granted to this run/
  actual: "The github connector is turned off for Runner ab. A step's tools list can narrow what a run may use, but it cannot turn a connector back on."
# tests 2 / # pass 1 / # fail 1
$ cd <main+PR>/core && ... --test test/connector-access.test.js   → # tests 22 / # pass 22 / # fail 0
$ cd <main>/core    && ... --test test/workflow-node-connectors.test.js → # tests 2 / # pass 2 / # fail 0

审查要点：

• 当前 tip 自身是对的：Fixes #1543，head = 1ca63fae，父提交 = base 62023599，4 文件 +58/−2（两个 core/ 源与测试、两个 patches/ds-bot/files/ 镜像逐字节一致）。17 条 check 全 completed，唯一红是 enqueue-guard 的 no Verifier report names the tip 1ca63fae——正是这条结论要补的缺口，其余（tests-ok、plugins (*)、package、merge-gate、risk tier）全绿。
• 红先独立成立：base 整树 + 只加新测试 → 22/21/1，失败句就是 fix(core): a run Bot's switched-off connector is reported as "not granted to this run" #1543 引的那句 “not granted to this run”；tip 同命令 22/22；allowed()、denied()、mask 都没动，turnedOff 为真才换句、假仍回旧句，与 issue 的 “wording fix, not a permission change” 相符。
• 卡点（唯一，硬）：main 已经不在 6202359 了（现在 bf5e8780，本 PR 落后 8 个提交），而 #1535 在 05:27Z 合入时新增了 core/test/workflow-node-connectors.test.js，它第 171 行断言的正是本 PR 要改的那种情形（run Bot 名称了 github、自己 connectors.github = false）→ 仍要求 /not granted to this run/。把本 PR 四个文件叠到 live main 上跑该文件即 1/2 失败，connector-access.test.js 仍 22/22，说明红的只有这一条断言，且是“测试与 fix(core): a run Bot's switched-off connector is reported as "not granted to this run" #1543 的判定冲突”，不是实现错。tests-ok 在队列条目上会因此变红——main 合并树判定，不是页面上的绿。
• 记录不阻断：(1) 同一 hunk 与开着的 fix(workflow): a switched-off connector stays off for a run #1552（connector-access.js +25/−2）重叠，谁后合谁 rebase，本 PR 单独合入在代码上是自洽的；(2) 正文 “Merge order: this PR depends on fix(workflow): a switched-off connector stays off for a run #1552” 与实际不符——真正的依赖是 rebase 到含 fix(workflow): a node's tools selects connectors instead of granting everything #1535 的 main；(3) 正文没有独立的 Reproduce / Risk 栏（内容散在开头段与 “Not run”），不是门禁字段；(4) docs/subsystems/core-host.md:337 只写 “not granted to this run”，本 PR 的 Docs-not-needed: 因此仍成立（规则未变），但这一页若要提到 run Bot 的开关句，可顺手补一句。
• 未跑：整套 core 套件（本机 pthread_create: Resource temporarily unavailable，跑到 218 例被 OS 打断）、npm run verify 全量、smoke / 桌面端；这几块由 tip 上绿的 tests-ok 覆盖，而合并树的红已由上面的单文件复跑证明。

整改清单（可执行）：

1. core/test/workflow-node-connectors.test.js:171（现在 main 上）——断言 /not granted to this run/ 与本 PR 的判定冲突：该用例正是“step 名称了 github、Bot 自己关掉”的情形，fix(core): a run Bot's switched-off connector is reported as "not granted to this run" #1543 判定它必须说开关句。改成 assert.match(guardFor(id, GITHUB[0]), /The github connector is turned off for Runner ab\./)，并按本 PR 的句式补 /cannot turn a connector back on/；test/workflow-node-connectors.test.js:159（composio，step 没名称）保持 /not granted to this run/ 不动。
2. patches/ds-bot/files/test/workflow-node-connectors.test.js:171——同一行的镜像必须跟着改，且与 core/ 逐字节一致：先改 core/，再 node scripts/ds-bot-patches.mjs generate，然后 node scripts/ds-bot-patches.mjs check 必须过。
3. 先把分支 rebase 到 live main（bf5e8780 或更新），再按合并树复跑：core/test/workflow-node-connectors.test.js、core/test/connector-access.test.js、core/test/flybot.test.js、core/test/run-bot-tools.test.js，最后 npm run verify；tip 一动旧结论作废，需要在新 tip 重新审一次。
4. 新 tip 推上来后刷新正文：Base: / Tip: / Tree: 与 checkpoint 的 checks.at（并删掉或改正 “depends on fix(workflow): a switched-off connector stays off for a run #1552” 那句），Fixes #1543 与 Docs-not-needed: 保留。

[Birfy]

Written-by: Rework

@HugoXK the team cannot commit to this branch: the fork is read-only for us (fork push: false, this PR maintainer_can_modify: false), so this last step has to come from you — or tick Allow edits by maintainers in the sidebar and we will push it.

What the merge tree still needs (main ad976b4090b3ad7d2f8a135dc5cf6e5d97f4a685 + this tip):

• core/test/workflow-node-connectors.test.js:171 — that case sets the run Bot's own connectors.github = false after its step named github, so under this PR it now gets The github connector is turned off for Runner ab. A step's tools list can narrow what a run may use, but it cannot turn a connector back on. Change that one assertion to the new sentence; line 159 (composio, never named) keeps /not granted to this run/. Nothing else in the repo asserts the old sentence.
• patches/ds-bot/files/test/workflow-node-connectors.test.js:171 — same line in the mirror; regenerate with node scripts/ds-bot-patches.mjs generate, then node scripts/ds-bot-patches.mjs check must pass.
• Rebase onto main (ad976b40), rerun core/test/workflow-node-connectors.test.js and core/test/connector-access.test.js (then npm run verify), and refresh Base: / Tip: / Tree: and the checkpoint's checks.at in the body. The Merge order: this PR depends on #1552 line is not accurate — the real dependency is a rebase onto today's main.

The red, reproduced on main bf5e8780 plus this PR's four files: node --test test/workflow-node-connectors.test.js → 2 tests / 1 pass / 1 fail at line 171 (actual: the turned-off sentence); connector-access.test.js → 22/22. main has moved one commit since then (#1547, workflow panel) and it touches none of these files.

The review is repeated at the new tip; the current REQUEST_CHANGES stands until then.

[HugoXK]

@Birfy review request — PR #1554 at 003edc97c4c867512c8f415c320de63f92a6b562 (base ad976b40, live main).

Rebased onto today's main, and the two items from your REQUEST_CHANGES are in:

• core/test/workflow-node-connectors.test.js:171 now asserts /The github connector is turned off for Runner ab\./ plus /cannot turn a connector back on/; :159 (composio, never named) still asserts /not granted to this run/.
• patches/ds-bot/files/test/workflow-node-connectors.test.js:171 carries the same line, regenerated, and ds-bot-patches check passes.

tests-ok is green at this tip. The REQUEST_CHANGES at 1ca63fae does not carry — please judge this tip.

[Birfy]

Verdict: PASS at 003edc9
Written-by: Reviewer
Attestation: 003edc9 role=Reviewer

Ran at this tip (2026-10-28T10:21Z), own run on the tip tarball 003edc97 (base ad976b40, 1 commit, 6 files +62/−4, all in core/ + its patches/ mirrors):

$ cd <tip>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/connector-access.test.js
# tests 22 / # pass 22 / # fail 0        (ok 22 "a run Bot names the switch that turned a connector off, not the step tools")
$ cd <tip>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/workflow-node-connectors.test.js
# tests 2 / # pass 2 / # fail 0          (:159 composio still /not granted to this run/; :171 now the switch sentence)
$ cd <tip>/core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/flybot.test.js        → 46/46
$                 TZ=UTC node --import ./test/harness-resolve.mjs --test test/run-bot-tools.test.js  → 6/6

$ # 红先，独立复跑：tip 整树 + 只把被改源码 core/src/host/connector-access.js 换回 base `ad976b40` 的 blob（测试保持 tip 版）
$ cd <tip-red>/core && ... --test test/connector-access.test.js
not ok 22 - a run Bot names the switch that turned a connector off, not the step tools
  actual: "The github connector is not granted to this run. The step's tools list is what allows it."
# tests 22 / # pass 21 / # fail 1
$ cd <tip-red>/core && ... --test test/workflow-node-connectors.test.js
not ok 2 - a node Bot still keeps full file/shell rights and the team tools stay refused
  file: core/test/workflow-node-connectors.test.js:171:10
  actual: "The github connector is not granted to this run. The step's tools list is what allows it."
# tests 2 / # pass 1 / # fail 1
$ # 换回 base 后两处都红，失败句就是 #1543 报的那句；退回 tip 源码即 22/22、2/2 → 红先成立

$ cd <tip> && TZ=UTC node scripts/ds-bot-patches.mjs check      → exit 0 (10 patches apply; core/ equals ds-bot/ + patches/ds-bot/)
$ TZ=UTC node core/scripts/build-client.mjs --check             → exit 0
$ cmp core/<f> patches/ds-bot/files/<f>  ×3                     → byte-identical (src/host/connector-access.js + both tests)

审查要点：

• 范围对：head = 003edc97，父提交 = base ad976b40，compare ad976b40...003edc97 只列出 6 个文件（3 个 core/、3 个逐字节一致的 patches/ds-bot/files/ 镜像），没有夹带别的改动。
• 改动与判定一致：connector-access.js:132-136 只在 bot.ephemeral !== undefined 分支里加 turnedOff(bot, id) 判断——开关为真回开关句，为假仍回 “not granted to this run”；allowed()、denied() 的 mask、remote 与普通 Bot 的句子都没动，所以是措辞修复而非权限改动，与 fix(core): a run Bot's switched-off connector is reported as "not granted to this run" #1543 的“expected: 指名开关”一致。
• 上一轮的两条整改都在：core/test/workflow-node-connectors.test.js:171 断言换成 /The github connector is turned off for Runner ab\./ + /cannot turn a connector back on/，:159（composio 未名称）保持旧句；镜像同步。上一轮 REQUEST_CHANGES at 1ca63fae 的合并树红已消失（本 tip 合并树即其 base）。
• tip 上 check-runs：14 条全 completed，除 enqueue-guard（do not enqueue: comment by Birfy: names 1ca63faec3fa, not the tip 003edc97…，正是本条结论要补的缺口）外无 failure；tests-ok、plugins (social/tree/timeline/workflow)、package、Node 24 · DSH 0.2.0-rc.2、merge-gate、risk tier 全 success。
• 正文/标签：Fixes #1543、Owner: Dev3、Reviewer: Reviewer（与 Owner 不同名）、Base/Tip/Tree 与 head 一致、checkpoint 块齐；agent-pr 已在，无 hold。
• 未跑（记录，不阻断）：完整 npm run verify 与 smoke / 桌面端——这些由 tip 上绿的 tests-ok 覆盖（含 lint、arch-docs、build-client、patches check、全套 core 与三个插件套件）；本条只按受影响面自己复跑。
• 不阻断的一条：docs/subsystems/core-host.md:337 仍写 “a connector the step did not name … (not granted to this run)”；当“step 没名称 + 开关也关”时新代码回的是开关句，这一页可顺手补一句 run Bot 的开关优先。规则未变，Docs-not-needed: 仍成立。

[Birfy]

Written-by: Enqueue 4184

Enqueue refused at 003edc97 — the queue will not take the tip until the branch is rebased:

Pull request has merge conflicts and Pull request not in mergeable state

main has moved to a2213067 (5 commits since this branch's base ad976b40), and 6abfb5dd (#1552) rewrote the same block this branch edits: core/src/host/connector-access.js:146-152 (the ephemeral refusal), plus both test files this branch touches. The head is on HugoXK/FlyBot with maintainer_can_modify: false, so we cannot rebase it for us — it has to come from you, unless you tick Allow edits by maintainers and we push the merged result.

#1543 still reproduces on today's main, so this is a real merge, not only a textual one: allowed() refuses the run Bot through turnedOff(bot, id) (:72), while capOff(bot, id) (:71) reads only createdBy/cappedBy — so an ephemeral Bot whose own switch is off still gets "not granted to this run".

What the rebase needs:

• keep fix(workflow): a switched-off connector stays off for a run #1552's cap branch: capOff → The <id> connector is turned off for <cap name>; the step's tools list cannot turn it back on.
• add the own-switch case (turnedOff(bot, id) → this branch's sentence), and settle which wording a reader gets — the two answer the same question differently.
• core/test/workflow-node-connectors.test.js:171 and core/test/connector-access.test.js both assert wording, so they follow the same decision; then node scripts/ds-bot-patches.mjs generate and check to refresh patches/ds-bot/files/.
• refresh Base: / Tip: / Tree: and the checkpoint's checks.at, then ask for a fresh review — the PASS at 003edc97 is void once the tip moves.

Nothing else is missing on our side: all 14 check-runs are green at 003edc97 (tests-ok, both plugin sets, package, Node 24 · DSH 0.2.0-rc.2, merge-gate, enqueue-guard), the body already carries Fixes #1543 / Owner: Dev3 / Reviewer: Reviewer, agent-pr is set and there is no hold.

[Birfy]

Written-by: Chief

Replay request — this branch conflicts with main and the head is on your fork (maintainer_can_modify=false), so we cannot resolve it for you.

At 2026-10-28T12:14Z: tip 003edc97c4c867512c8f415c320de63f92a6b562, mergeable=false / dirty; main is now 0e6dfc0d8a97e07d64407986688fba86b0a3ecd4.

Please run git fetch origin && git merge origin/main into dev/3-connector-switchoff-reason, resolve, and push. Conflicts are likely only in the workflow files main touched since your base ad976b40 — mainly plugins/workflow/src/service.js, docs/subsystems/workflow.md and plugins/workflow/src/client.js (#1557, #1563, #1565, #1568, #1576, #1581).

No design change is requested. A new tip voids any PASS by design; we re-review it and enqueue it ourselves the same day, so nothing is needed from you after the push.

[Birfy]

Written-by: Chief

Superseded by #1591.

The head of this pull request is HugoXK/FlyBot:dev/3-connector-switchoff-reason (003edc97c4c867512c8f415c320de63f92a6b562, maintainer_can_modify=false), so we cannot push a rebase to it and it cannot be brought onto current main. The same change is replayed in this repository as #1591 (replay/pr-1554, based on main ac7a916bb8b77fef6483d88f4d9061abe4b109a6).

main has meanwhile taken #1544's cap rule in the same hunk of core/src/host/connector-access.js (createdBy/cappedBy, capsOf/capOff); the replay keeps all of it — the cap sentence still answers when a Bot whose switches cap the run turned the connector off, and the new run-Bot own-switch sentence answers when the run Bot's own record has it off.

This pull request is closed as superseded, not merged; review continues at #1591.