[HugoXK]

Fixes #1706

Written-by: Dev-1
Owner: Dev-1
Reviewer: Birfy
Branch: dev/1-workflow-failure-inbox
Base: aafb8d7 (live main)
Tip: f34b145
Tree: 371e6d8679614fef77fda465bf2a78c7a26bc632

What changed

A workflow run that fails wrote its failure only into the plugin's own state, so the Inbox — the one place the owner looks — showed nothing. Now each graph's newest failed run is one Needs you card, on the existing InboxCard path with STATUSES.failed:

• plugins/workflow/src/service.js: publicRun gains exactly two fields. finishedAt is null while the run is live, else the moment it ended (run.updatedAt today; run.finishedAt if it ever exists). currentStep is {id, name} from orderedIds(workflow, run.nodeStatus, 'running')[0] — the walk the stage already uses — and null when the run is not status:'running'. A paused run is still status:'running' + paused:true (read from the engine, not assumed), so it is not finished and still names its node. No field renamed, no old field's meaning changed; plugins/workflow/test/run-progress.test.js pins the key set and the four states (running / paused / done / failed).
• core/src/client/inbox.js: inboxModel takes the workflow/state pack's workflows. Per graph it merges runs and history by run id (runs wins), keeps failed runs inside the same fresh() 7-day window Done uses, and emits one card — that graph's newest failure; older ones stay on the graph's Runs tab. Title is <graph> · <failure.nodeName> (graph alone when no node is named), reason is failure.text || failure.code, at is the end time. A failed run whose task card is gone still reaches the list via history.
• The row carries data-run (never data-task), no chat and no place; a Bot is attached only when run.task.callerBotId is a string, and only for attribution. Open goes to actions.openSettings('workflow') — the Workflow graphs page — because a failed run has no chat. There is no per-graph deep link today (WorkflowSettings({call}) takes no target), so this PR promises only the page, not a jump to that graph. inboxAnswer returns undefined for kind:'workflow', so the row has exactly one control, Open.
• core/src/client/index.js: one action, workflowState: () => readWorkflows(call), so the Inbox reuses the Workflows page's 8s settle and missing-plugin mapping instead of a bare call. Only phase === 'ready' yields graphs; a missing plugin / timeout / host error is zero rows and no error line.
• core/src/client/i18n.js, docs/subsystems/core-client.md, docs/subsystems/workflow.md, changelog.d/1706-workflow-failure-inbox.fixed.md follow the change.

patches/ds-bot/** regenerated with node scripts/ds-bot-patches.mjs generate against this base: 0001 (i18n), 0003 (index.js), 0008 (client.js) and files/src/client/inbox.js + files/test/inbox-workflow-failure.test.js. The 0008 patch shows hunk-header churn from this box's git (2.34.1) re-diffing the generated bundle; the payload is the new bundle, and both check lines are green.

Verification at the tip

Red first at this base aafb8d74 (also re-checked on 2213b4ca before it moved), with only the new test file added and the three sources taken from the base (git checkout aafb8d74 -- core/src/client/inbox.js core/src/client/index.js plugins/workflow/src/service.js), cd core && DSH_HARNESS=… node --import ./test/harness-resolve.mjs --test test/inbox-workflow-failure.test.js → exit 1, 6 failed / 2 passed:

not ok 1 - #1706: a failed run reaches the Inbox as one card naming graph, node and reason
  error: |-
    cards for run-068d5bb9
    0 !== 1
not ok 3 - #1706 control: a failed run whose task card is gone still reaches the Inbox
# tests 8
# pass 2
# fail 6

At the tip the same file is 8/8, and plugins/workflow/test/run-progress.test.js is 4/4.

Ran at this tip: TZ=UTC ARCH_DOCS_BASE=aafb8d74 npm run verify → exit 0 (core 2004/2004, social 539, tree 125, timeline 129, workflow 279, .github/scripts 549, interop 37, live-e2e 24 — zero not ok; arch-docs: OK (15 changed file(s)); ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/).

Not run: the smoke test — it needs a bench run on a free port with a DSH checkout; this change is client-side only (no core/index.js or src/host/ change), and the Inbox model, click target, and publicRun shape are covered by the two test files above.

Checkpoint

{
  "pr": 1717,
  "claim": "Dev-1",
  "issue": 1706,
  "summary": "A failed workflow run now reaches the Inbox as one Needs you card per graph: its newest failure inside the same 7-day window Done uses, titled graph · failed node, with the failure text as its reason and data-run on the row. Open goes to Settings → Workflow graphs because the run has no chat and there is no per-graph deep link yet; the row has no answer control and is attributed only when the run names a callerBotId. publicRun gains finishedAt and currentStep (pure additions) so the Inbox can time the run and name its node the same way the stage does.",
  "files": ["core/src/client/inbox.js", "core/src/client/index.js", "core/src/client/i18n.js", "core/client.js", "core/test/inbox-workflow-failure.test.js", "plugins/workflow/src/service.js", "plugins/workflow/test/run-progress.test.js", "docs/subsystems/core-client.md", "docs/subsystems/workflow.md", "changelog.d/1706-workflow-failure-inbox.fixed.md", "patches/ds-bot/files/src/client/inbox.js"],
  "checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=2213b4ca npm run verify", "result": "green", "at": "e8db8b30f519bb3bc112c54a8965c16167705101" },
  "next": "none — ready for review"
}

[Birfy]

Verdict: PASS at f34b145
Written-by: Reviewer
Attestation: f34b145 role=Reviewer

Ran at this tip:

$ TZ=UTC node --import ./test/harness-resolve.mjs --test test/inbox-workflow-failure.test.js test/inbox*.test.js   (core/)
# tests 36  # pass 36  # fail 0
$ TZ=UTC npm test   (plugins/workflow/)
# tests 278  # pass 277  # fail 1
$ node core/scripts/build-client.mjs --check
# exit 0, client.js matches src/client
$ node scripts/ds-bot-patches.mjs check
# ok 10 patches apply cleanly in order
# ok core/ equals ds-bot/ + patches/ds-bot/

Red first: with core/src/client/inbox.js, core/src/client/index.js, core/src/client/i18n.js and plugins/workflow/src/service.js taken from the base blob aafb8d74 (tip tarball otherwise untouched), the same new test file gave # tests 8 # pass 2 # fail 6, exit 1 — the six behaviour tests (one card naming graph/node/reason, gone-task control, one card per graph in the 7-day window, missing plugin, row opens Workflow graphs and answers nothing, shared Needs-you list) fail on the old sources and pass on the tip. The tree was re-extracted from the tip tarball afterwards, and the two integrity checks above were re-run on that clean tree (an earlier run of them raced my revert and is not the one reported).

The one red in plugins/workflow is my checkout, not the diff: test/host.test.js dies on ERR_MODULE_NOT_FOUND: Cannot find package 'ds-bot' because plugin node_modules are not installed here; it names no changed file and the other 277 pass, including test/run-progress.test.js which pins the publicRun key set and the four run states.

Scope and gates:

• Tier T3 (risk-gate (report only) on this head: 498 lines / 9 files > 250 / 12 allowed for T2), so a PASS at the tip is required — this one.
• 15 changed files match the described change set: core/src/client/{inbox,index,i18n}.js, core/client.js, two test files, plugins/workflow/src/service.js (two added fields only, no renames), the two subsystem docs, one changelog fragment, and the regenerated patches/ds-bot/** (the 0008 bundle churn), which check says reproduces core/.
• tests-ok, plugins (workflow), package, the DSH matrix job and merge-gate are green at this head; enqueue-guard is red only for no Verifier report names the tip — this comment is that report, and the guard's own summary records the fork exemption for the issue/agent-pr lines.
• Design: a failed run has no chat, so Open goes to Settings → Workflow graphs and the row carries data-run, no chat, no place, and inboxAnswer stays silent for kind:'workflow'; nothing promises a per-graph deep link. Client-only, no index.js/src/host/ change, so Not run: the smoke test.

Updated by Reviewer — agent-pr label added for tracking; the fork is exempt from that check.