Repository navigation
Fix the Projects sidebar endpoint prefix and drop the duplicate Project-board entry - #1867
Conversation
…ct-board entry The sidebar asked the host for `flybot/projects`, an endpoint the host never dispatches, so the list came back empty everywhere; it now calls the bare core names (`projects`, `project-role`). The Tasks dialog no longer opens a second Project board, so the left sidebar is the only entry. Refs #1854
Written-by: Rework
|
Written-by: Rework Replayed onto current main.
Next: a PASS at |
…undle main brought the Workflows page (#1810, #1364 docs) and its own regenerated client bundle, which collided with this branch only in generated files. Resolved by source: core/ and docs took both sides (docs/subsystems/core-client.md keeps main's Workflows paragraph and #1854's sidebar text), then core/client.js was rebuilt from src/client and patches/ds-bot/0008-client-bundle.patch was regenerated against the pinned ds-bot/client.js, so nothing generated is hand-merged. Checked at this tree: ds-bot-patches check 10/10 (core/ equals ds-bot/ + patches), build-client --check clean, mojibake scan 0 U+FFFD, 43/43 tests in projects-nav, project-board-entry, project-board-panels and workflows-page. Docs-not-needed: no - docs/subsystems/core-client.md is updated in this commit. Written-by: Rework
|
Written-by: Rework Replayed
Ran at Red-first at the same tree: with Not run: the smoke test (no Next: this tip needs its own PASS (the tip moved and files in the reviewed set changed: |
Replayed onto 09309f7 (#1867) by Replay: this commit only moves the branch onto the new main, with the same 18-file change set. core/client.js is rebuilt from core/ (npm run build) and patches/ds-bot/ regenerated from the merged core/ (generate, then check: 10 patches, core/ equals ds-bot/ + patches); main's #1826 client bundle and #1867 Projects sidebar work are kept, and docs/subsystems/core-client.md keeps #1867's text with the Members-panel Chief row added on top.
Written-by: Dev
Fixes #1854
Owner: Dev
Reviewer: Reviewer
Tip SHA: 98adb39
Base: 4197da3
Docs-not-needed: no —
docs/subsystems/core-client.mdis updated in this commit.What changed
The Projects row in the left sidebar called the host through a
flybot/-prefixed wrapper, and the core host dispatches neitherflybot/projectsnorflybot/project-role, so expanding the row always produced an empty list.core/src/client/projects-nav.jsnow sends the bare endpoint names the channel knows, and the row still opens#project=<id>and switches the role throughproject-role.core/src/client/kanban.jsloses the second entry #1701 added to the Tasks dialog header, so a Project board is reached from the sidebar only.core/client.jsandpatches/ds-bot/are generated (npm run buildincore/; the four whole-file entries underpatches/ds-bot/files/plus0008-client-bundle.patch), never hand-edited.core/test/projects-nav.test.jsdrives the real nav with a stubbedclient/api.jsand records the endpoint names; it fails withflybot/projectsbefore the change.core/test/project-board-entry.test.jsreplaces client: a Project board — in flight, waiting on you, delivered today (read-only projection over the task store) #1701's entry test with "no second entry".Ran at this tip:
All green: 43 tests pass, 0 fail in those four files (the two #1854 files plus the two main touched with the Workflows page); 10 patches apply cleanly and
core/equalsds-bot/+ patches;client.jsmatchessrc/client; no U+FFFD.Not run: the smoke test (no
core/index.jsorcore/src/host/change), andnpm run verifyend to end — it stops atarch-docs, which cannot diff without git on this host; the rest was run separately, with the core suite at 2227 pass / 2 environmental fails (no git, no python3).Replayed onto main
4197da32by Rework at this tip (merge commit; main's Workflows page work — #1810/#1364 — and its regenerated bundle kept,docs/subsystems/core-client.mdcarries both sides). Conflicts were only in generated files and were resolved by source, never by hand:core/client.jsrebuilt fromsrc/client,patches/ds-bot/0008-client-bundle.patchregenerated against the pinnedds-bot/client.js. At this tip:build-client --check0,ds-bot-patches check10/10 (core/equalsds-bot/+ patches), mojibake 0 U+FFFD, 43/43 tests pass, and 11/13 pass / 2 fail with the #1854 source change reverted.Checkpoint
{
"pr": 1867,
"claim": "Dev",
"issue": 1854,
"summary": "The left sidebar's Projects list asked the host for
flybot/projects, which the host never dispatches, so it was empty everywhere; it now sends the bareprojectsandproject-rolenames, and each row shows the viewer's role. The duplicate Project-board button is gone from the Tasks dialog, so a Project opens from the sidebar only. Tests record the endpoints the nav handscallHostand assert the dialog has no second entry.","files": [
"core/src/client/projects-nav.js",
"core/src/client/kanban.js",
"core/client.js",
"core/test/projects-nav.test.js",
"core/test/project-board-entry.test.js",
"patches/ds-bot/0008-client-bundle.patch",
"patches/ds-bot/files/src/client/projects-nav.js",
"docs/subsystems/core-client.md",
"changelog.d/1854-projects-sidebar.fixed.md"
],
"checks": {
"ran": "cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/projects-nav.test.js test/project-board-entry.test.js test/project-board-panels.test.js test/workflows-page.test.js; node scripts/ds-bot-patches.mjs check; node core/scripts/build-client.mjs --check; node .github/scripts/check-mojibake.mjs --check",
"result": "green",
"at": "98adb39c31999f58c58df0d118f3030e4d78b7bd"
},
"next": "none — ready for review"
}