Repository navigation
Branding: Wingbot logo + wordmark, README hero and architecture - #43
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cfbf13c74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <a href="https://github.com/ThinkFlowLab/FlyBot/actions/workflows/test.yml"><img alt="Test" src="https://github.com/ThinkFlowLab/FlyBot/actions/workflows/test.yml/badge.svg?branch=main"></a> | ||
| <img alt="DSH" src="https://img.shields.io/badge/DSH-0.2.0--rc.2-4D6BFE"> | ||
| <a href="https://github.com/ThinkFlowLab/FlyBot/actions/workflows/nightly.yml"><img alt="Nightly" src="https://github.com/ThinkFlowLab/FlyBot/actions/workflows/nightly.yml/badge.svg?branch=main"></a> | ||
| <a href="https://github.com/ThinkFlowLab/FlyBot/actions/workflows/codeql.yml"><img alt="CodeQL" src="https://github.com/ThinkFlowLab/FlyBot/actions/workflows/codeql.yml/badge.svg?branch=main"></a> |
There was a problem hiding this comment.
Drop the badge for the deleted CodeQL workflow
At this commit a repo-wide workflow/path search finds only test.yml, nightly.yml, and release.yml; codeql.yml was deleted before this commit. Consequently both this link and its badge URL point at a workflow that cannot run, leaving a broken badge while misleading readers that CodeQL is active. Remove the badge or restore the workflow.
Useful? React with 👍 / 👎.
A Bot's line to a friend's Bot that is only in a room with it was refused with no_relationship: bot-social decides reach from the pair's grants, and a room claim writes a status='room' relationship that findActiveRelationship does not read (#866, bot-social #43/#50). Both send paths now name the room on send_as_member when roomContextFor finds one open room here that holds both Bots, so the server's room-scoped grant is the reach the pair already holds. Room lines (via room/room-share) and a local shared room (#864) name none: a local room has no id on the server, and naming one only earns room_not_shared. A room-scoped refusal is reported as the room's answer, never retried on another Bot of mine.
A Bot's line to a friend's Bot it only shares a room with was refused no_relationship: Bot Social decides reach from the pair's relationships, a room claim writes status='room', and findActiveRelationship reads only 'active' (#866, bot-social #43/#50). Both send paths now name the room on send_as_member when roomContextFor finds one open face room here that still holds both Bots, so the server's room-scoped grant is the reach the pair already holds. Room lines and a local room (#852) name none: a local room has no id on the server, and naming one only earns room_not_shared. A room-scoped refusal is reported as the room's answer and never retried on another Bot of this home. Rebuilt from c90af02: the previous tip cf907be was cut from a 38629bf tree and silently reverted #869.
Summary
Follow-up branding work after #27 (merged).
#3B5BFD, wing#8FB2FF, dark-mode#6E87FF/#A9C2FF). It reads at 16 px.scripts/logo.mjsnow draws it and also writes a wordmark lockup (logo-wordmark.svg,logo-wordmark-dark.svg). Regenerateddocs/images/logo*.svgand the PNGs (16, 32, 180, 192, 512, dark, wordmark).<picture>), Test and Nightly badges (CodeQL dropped with ci: turn off CodeQL #38), a new How FlyBot is built section (upstream core pinned inds-bot/+ds-bot.pin.json, FlyBot patch layer inpatches/, builtcore/, plugins inplugins/; see Decouple the social and tree plugins from ds-bot so the core can track upstream #34). Removed the License and Disclaimer sections that appeared twice. Install paths match current main after the plugins move landed in Decouple plugins: tree and social as peer plugins under plugins/ (#34 PR 2, stacked on #37) #40:path:/core,path:/plugins/social,path:/plugins/tree.No changes to
ds-bot/,core/or plugin code.Screenshots
Not retaken in this PR. The shared build box was heavily overloaded (load 30–56 on 8 cores), and headless Chrome or DSH web timed out every time. The existing
docs/images/{team,details,group,usage}.pngare kept. A follow-up will retake them in English with social and tree visible (the mock setup is ready).Closes #32