Repository navigation
Keep children's load out of a tree coordinator's system prompt (#895) - #898
Merged
Merged
Conversation
…FlowLab#895) The Child load line changed the coordinator's tree block at every child turn start and end, so its whole system prompt changed and DSH re-sent all of it on the next step. list_children already reports load, openForMs and stalled live; the coordinator rules now point there in fixed words. Refs ThinkFlowLab#796
…kFlowLab#895) Load only breaks a tie between children whose scope fits, so a part with one fitting child costs no extra tool call. Refs ThinkFlowLab#796
Birfy
force-pushed
the
fix/895-tree-load-line
branch
from
October 23, 2026 17:46
bbc5f0e to
3d4e268
Compare
Collaborator
Author
|
Verdict: PASS at 3d4e268 Ran:
Not run: smoke bench, Desktop, a real-model run. Findings: no actionable findings.
Security fence / display-name: not in scope (no remote text or fencing touched). Disclosure: the same executor session that wrote this PR ran this review (owner's instruction to fix these together; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #895
Refs #796
A tree coordinator's system prompt carried
Child load right now — Dev: working, Test: idle …(#507, #624).plugins/tree/index.jsrewrites the tree block at everyturn.start/turn.endof a tree Bot, so the coordinator's system prompt changed at every child turn boundary (and every minute for a stalled child). On DeepSeek DSH then appends the whole changed system prompt after the history (systemPromptUpdate: "in-history"); on other routes the cached head misses.The load line is gone from the prompt (
notesForonly: renames, roles and other fixed notes still refresh the block, andwriteBlockskips an unchanged block). Coordinator rule 3 now says once, in fixed words: when more than one child fits a part, calllist_childrenbefore sending it, and prefer an idle or working child to a busy one. Load only ever broke a tie between children whose scope fits, so a part with one fitting child costs no extra call.list_childrenalready returns each child'sload,openForMsandstalledlive (#507, #624, #733), so the coordinator reads the same facts, fresher, when it routes.loadLinestays a pure helper inload.js(its own tests keep it); the prompt no longer calls it.Token measurement (plugin test harness, same workload before/after)
c90af02list_childrencall when more than one child fits a part (a few hundred chars)Verification at
3d4e268057209eda3ba85770b6a01abc095405a3(rebased onb54f38a)TZ=UTC ARCH_DOCS_BASE=origin/main npm run verify→ pass (core 1328/1328, plugins 395 + 125 + 125 + 332 + 37 + 16, arch-docs OK, patches check OK).plugins/tree/test/tree.test.js(prompt byte-stable across a child's turn start/end) fails onc90af02, passes here.Not run: smoke bench, Desktop, a real model.
Docs:
docs/subsystems/tree.md§ Runtime load. Changelog:changelog.d/895-tree-load-line.fixed.md.