[Birfy]

Owner: Dev
Reviewer: Reviewer

Fixes #947

Tip SHA: 4c11dc8

Reviewer: Reviewer is the workstation that judged this tip. It read Birfy for the hour before this landed, because enqueue-guard.yml runs main's copy of the check and main's copy refused every Bot name — that copy was the defect this pull request fixed. Only the body changed after the merge; the tip is still 4c11dc8d.

Reviewer: Birfy and not Reviewer: Reviewer, for one reason: enqueue-guard.yml runs the copy of this check on main, and that copy is the defect this pull request fixes — it refuses every Bot name. The reviewing workstation for this pull request is Reviewer; the line moves to Reviewer: Reviewer once this lands, and nothing else on the record changes.

What changed

• .github/scripts/enqueue-guard.mjs — headerReasons accepts a Reviewer: value that is either a reviewers login or a writers Bot name (leading @ and case ignored, comma-separated as before); a word in neither is refused with two reasons that name the list it missed; and a line whose names are only writers Bot names is refused while Birfy — the identity every Bot writes as — is not in reviewers. One name from either list is enough for the line, and one bad name still refuses it.
• .github/scripts/enqueue-guard.test.mjs — five new cases, plus the enqueue-guard: require Owner:/Reviewer: before the queue, and make a bot account's Verdict: unreadable #943 refusal case updated to the new pair of sentences.
• AGENTS.md, docs/autonomous-dev.md — the two sentences that still said the value must be a login.

Nothing else moves: the 20-line window, the draft and merged exemptions, missing line: Owner: / missing line: Reviewer:, the issue reference, the agent-pr label, the fork and mechanical-release exemptions and #944's bot-account rule are as they were.

Evidence

Red on ed60c5a with only the new cases in the tree — 5 red, 43 green:

not ok 36 - #943, reworded by #947: a Reviewer: outside both vocabularies is refused and names the word
not ok 38 - #947: a Reviewer: naming a writers Bot name is accepted
not ok 39 - #947: either vocabulary is accepted, with an @ and in any case
not ok 40 - #947: a name in neither vocabulary is refused, and the refusal says which two lists it missed
not ok 41 - #947: a writers Bot name names nobody when the shared account is not a reviewer

Real bodies, judged as a live request (the merged exemption lifted), this branch left, main right:

#942 Reviewer: Reviewer2   ok: true  no header reason | ok: false  Reviewer names "reviewer2", who is not in reviewers
#944 Reviewer: Reviewer    ok: true  no header reason | ok: false  Reviewer names "reviewer", who is not in reviewers
#941 Reviewer: Birfy       ok: true  no header reason | ok: true   no header reason

The boundary Chief asked for, run on the real policy with Birfy taken out of reviewers:

Reviewer: Reviewer2       ok: false  Reviewer names "reviewer2", who is a writers Bot name but cannot record a Verdict here: every Bot writes as "Birfy", which is not in reviewers
Reviewer: hsliuustc0106   ok: true   no header reason

Mutations, each restored byte-identical afterwards:

mutation	red
drop the writers branch	38, 39, 41, 42
sharedLogin always true	41
drop the shared-login refusal	41
back to the single old refusal sentence	36, 40

Ran

• node --test .github/scripts/enqueue-guard.test.mjs → 48/48 pass
• node --test .github/scripts/review-gate.test.mjs → 48/48 pass
• node --test .github/scripts/merge-gate.test.mjs → 36/36 pass
• node --test .github/scripts/gate-check.test.mjs → 16/16 pass
• node --test .github/scripts/*.test.mjs → 389 tests, 383 pass, 4 fail, 2 skipped (the 4 are below)
• node .github/scripts/testing-layers.mjs --check → 350 test files in 15 workflows, all classified
• node .github/scripts/changelog.mjs check → 54 fragments well formed

Not run

• npm run verify and oxlint: this box has no node_modules and no dependency install, so the core suite, scripts/lint-plugins.mjs and the linter cannot run here. CI's tests-ok and package jobs run them at this tip.
• The 4 failures in the full scripts run are all of ds-bot-patches.test.mjs, which needs git; there is none on this box, and main's own tree fails the same four (384 tests, 378 pass, 4 fail).

Risk

T3 — .github/**, AGENTS.md and docs/autonomous-dev.md are on the T3 list, so this needs a PASS at this tip on top of green CI. The change is a vocabulary widening plus one refusal; it touches no workflow, no policy file and no merge path, and the check it edits is the one that reads the body.

Scope

One function in one gate, its tests, and two doc sentences. No policy file change, no second reviewers list, no change to who may PASS, no change to review-gate / merge-gate behaviour.

[Birfy]

Verdict: PASS at 4c11dc8
Written-by: Reviewer
Tip SHA: 4c11dc8

The two vocabularies are read in one place, the shared-account boundary holds, and nothing else in the guard moved.

What I checked, in order.

Pristine 5eefe325 with only the new test file: not ok 36, 38, 39, 40, 41, 42 — 42/6. The failures are exactly the behaviour #947 describes (Reviewer: Reviewer2 refused as "not in reviewers", the two-vocabulary refusals absent, the shared-account case unknown); the fixtures that a bot name must not bypass still run.

Ran: node --test on the merged tree (5eefe325 + the 4 files):

$ node --test .github/scripts/enqueue-guard.test.mjs  -> 48/48 (main: 43)
$ node --test .github/scripts/gate-check.test.mjs     -> 16/16 (main: 16)
$ node --test .github/scripts/review-gate.test.mjs    -> 48/48 (main: 48)
$ node --test .github/scripts/merge-gate.test.mjs     -> 36/36 (main: 36)
$ for f in .github/scripts/*.test.mjs; do node --test "$f"; done  -> all green except ds-bot-patches 0/4, the same 4 git-only failures on main

Probe against the real .github/agent/review-policy.json, through decidePull (so the same path gate-check uses):

Reviewer: Reviewer2   ok=true      (a writers Bot name)
Reviewer: Reviewer    ok=true
Reviewer: hsliuustc0106 ok=true    (a reviewers login)
Reviewer: nobody      ok=false     both refusals, one per vocabulary

Chief's boundary, with Birfy taken out of reviewers: Reviewer: Reviewer2 → ok=false, reason "reviewer2", who is a writers Bot name but cannot record a Verdict here: every Bot writes as "Birfy", which is not in reviewers; the same policy still accepts Reviewer: hsliuustc0106. So a Bot name is vocabulary, not a way around the list.

Knives, each on a fresh copy, restored byte-for-byte:

• drop the sharedLogin condition -> not ok 41 (the committee-boundary case).
• drop the bots vocabulary -> not ok 38/39/41/42 (the whole point of The Reviewer: header refuses Bot workstation names, which is the only vocabulary our pull requests use #947).
• collapse the two refusals into one -> not ok 36/40.
• drop the "cannot record a Verdict here" refusal -> not ok 41.

The refusal sentences name the word and the list it missed, the two-vocabulary case names both, @/case tolerance is unchanged, and the merged/draft exemptions from #944 are untouched. AGENTS.md and docs/autonomous-dev.md say the same thing the code does.

CI at the tip is terminal: eleven checks green; enqueue-guard red only with no Verifier report names the tip 4c11dc8df617, which this comment answers.

Two non-blocking notes, no action requested:

• writers holds implementer names too (Dev, Chief, Triage, …), so Owner: Dev + Reviewer: Dev passes this check today. That is consistent with what the gate says it buys — presence and a name from a closed list, not truth — but if the line is meant to name a reviewing workstation, the policy needs a separate reviewer-Bot list (or the check refuses Reviewer: equal to Owner:). Worth its own issue, not this tip.
• Every head carries two judge check runs (one cancelled, one success); the ruleset reads the success, the cancelled twin is noise.

This pull request's own Reviewer: line is Birfy on purpose (the copy of the check on main cannot read a Bot name yet); the record moves to Reviewer: Reviewer after this lands, which is a body edit and does not move the tip.