Fix missing assets in Docker image#224
Conversation
|
Someone is attempting to deploy a commit to the ThisIs-Developer Team on Vercel. A member of the Team first needs to authorize it. |
|
For reference, this is how the published Docker image behaves before this change. The missing toolbar icons are caused by assets/lucide-icons.css returning 404. After this PR, the icons render correctly. Before: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the root Nginx-based Docker image to ship the full assets/ directory so Docker deployments don’t 404 on required static assets (notably assets/lucide-icons.css), restoring correct toolbar icon rendering.
Changes:
- Copy the entire
assets/directory into/usr/share/nginx/html/assets/instead of onlyassets/icon.jpg.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you @Kechos23, for identifying and fixing this issue! Contributions like this make the application more reliable for everyone using Docker. I really appreciate your support for the community! |
|
Thank you @ThisIs-Developer ! I really enjoy the project, so I'm happy I could contribute. Thanks for the quick review and merge! |
Summary
The Docker image currently copies only
assets/icon.jpg, while the application also references additional files from theassetsdirectory, such asassets/lucide-icons.css.As a result, requests for missing assets (for example
assets/lucide-icons.css) return404, causing toolbar icons to be missing in Docker deployments.I noticed this because the live preview renders correctly, while a container created from the published Docker image does not.
Change
Testing
/assets/lucide-icons.cssreturns200 OK