Harden PR workflow support#228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Phase 2 PR workflow hardening plan for Agents Shipgate.
check_run_policywith advisory, blocked-fails, and require-mergeable modes for branch-protection-ready Check Runs.init --cito generate a PR-first advisory workflow withfetch-depth: 0,diff_base: target, annotations, and PR comments.--jsonto--format jsonchurn in agent-facing docs/renderers.check_run_policyinput and documentsblocked-failsexplicitly.Review fixes addressed
PRIOR_RENDER_SHA256migration is needed.--jsonchanges output semantics.10-check-run-annotations.ymlnow targets@mainand omitsshipgate_versionuntil a release containscheck_run_policy.blocked-failspolicy: documented in the Check Run mapping contract and GitHub Actions examples.Validation
PYTHONPATH=src python -m pytest tests/test_github_action_annotations.py tests/test_github_check_run.py tests/test_action_metadata.py tests/test_init_ci.py tests/test_public_surface_contract.py tests/test_adapter_static_only.py tests/test_verify.py -q-> passedPYTHONPATH=src python -m pytest->3137 passed, 5 skippedPYTHONPATH=src python -m ruff check .-> passedPYTHONPATH=src python -m compileall -q src tests scripts-> passedgit diff --check-> passedAGENTS_SHIPGATE_AGENT_MODE=1 PYTHONPATH=src python -m agents_shipgate check --agent codex --workspace . --format agent-json->decision=allowAGENTS_SHIPGATE_AGENT_MODE=1 PYTHONPATH=src python -m agents_shipgate verify --workspace . --config shipgate.yaml --base origin/main --head HEAD --ci-mode advisory --format json->merge_verdict=mergeable,can_merge_without_human=true,release_decision=passed