Potential fix for code scanning alert no. 6: Failure to use secure cookies#1054
Draft
shaneahmed wants to merge 2 commits intodevelopfrom
Draft
Potential fix for code scanning alert no. 6: Failure to use secure cookies#1054shaneahmed wants to merge 2 commits intodevelopfrom
shaneahmed wants to merge 2 commits intodevelopfrom
Conversation
…okies Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TissueImageAnalytics/tiatoolbox/security/code-scanning/6
Set the
session_idcookie withsecure=Trueso browsers only send it over HTTPS. Keep existing behavior intact by preserving the same cookie name/value andhttponly=True, and only adding the missing security attribute.Best single change:
tiatoolbox/visualization/tileserver.pysession_idmethod, line withresp.set_cookie(...)(around line 393)resp.set_cookie("session_id", session_id, httponly=True)resp.set_cookie("session_id", session_id, httponly=True, secure=True)No new imports, methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.