Skip to content

fix text ,card visibility in light mode #118

Closed
omkarhole wants to merge 5 commits into
TiwariDivya25:mainfrom
omkarhole:fix/text-contrast-in-light-mode
Closed

fix text ,card visibility in light mode #118
omkarhole wants to merge 5 commits into
TiwariDivya25:mainfrom
omkarhole:fix/text-contrast-in-light-mode

Conversation

@omkarhole

@omkarhole omkarhole commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes text visibility and card in light mode

Fixes : #92
Screenshot 2026-01-09 163730
Screenshot 2026-01-09 163823
Screenshot 2026-01-09 163757
Screenshot 2026-01-09 163743

@TiwariDivya25 please review it

@vercel

vercel Bot commented Jan 9, 2026

Copy link
Copy Markdown

@omkarhole is attempting to deploy a commit to the Divya Tiwari's projects Team on Vercel.

A member of the Team first needs to authorize it.

@netlify

netlify Bot commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for tiwaridivya25-devconnect failed.

Name Link
🔨 Latest commit 6b86006
🔍 Latest deploy log https://app.netlify.com/projects/tiwaridivya25-devconnect/deploys/6999ece50b2f7700081b05c1

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

1 similar comment
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@sharathlingam

sharathlingam commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@omkarhole

issue : #92

Change this to
Fixes #92

Can you fix the color for the button text colors as well?

sharathlingam
sharathlingam requested changes Jan 9, 2026
View reviewed changes
Comment thread src/theme.css
Comment thread src/pages/ProfilePage.tsx Outdated
@sharathlingam

sharathlingam commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

@omkarhole make the changes and commit to this pr.

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@omkarhole

omkarhole commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

@TiwariDivya25 i have fixed the issue please review it

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@TiwariDivya25

TiwariDivya25 commented Jan 11, 2026

Copy link
Copy Markdown
Owner

@TiwariDivya25 i have fixed the issue please review it

Please resolve merge conflicts and sync your branch.

@github-actions

github-actions Bot commented Jan 14, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@omkarhole

omkarhole commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

@TiwariDivya25 fixed .

@sharathlingam

sharathlingam commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

@TiwariDivya25 fixed .

Hey @omkarhole, in this PR, you've overridden the default Tailwind CSS behavior in the global CSS file, which is not recommended when using Tailwind. Could we explore a more suitable solution? Thanks for your understanding!

@github-actions

github-actions Bot commented Feb 21, 2026

Copy link
Copy Markdown

👋 Hi @omkarhole,
This pull request does not seem to be linked to an issue.

Please link an issue using one of the following formats:

Linking issues helps us track work and close issues automatically. Thanks! 🙌

@omkarhole omkarhole closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharathlingam sharathlingam sharathlingam requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In Light mode text contrast is too low across multiple pages

3 participants

@omkarhole @sharathlingam @TiwariDivya25