Skip to content

Improve llmdoc update workflow#28

Merged
Disdjj merged 1 commit into
mainfrom
important-spot
May 23, 2026
Merged

Improve llmdoc update workflow#28
Disdjj merged 1 commit into
mainfrom
important-spot

Conversation

@Disdjj

@Disdjj Disdjj commented May 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@Disdjj Disdjj merged commit 456c9ed into main May 23, 2026
1 of 2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the llmdoc plugin to version 2.1.0, introducing a more flexible and efficient documentation update workflow. Key changes include the implementation of three update modes (fast, analysis, and full) to optimize the balance between speed and investigation depth, the introduction of a local temporary context cache in .llmdoc-tmp/ for investigator scratch reports, and an automated active-memory archiving process. Documentation across READMEs, agent prompts, and skills has been synchronized to reflect these new protocols. Review feedback identifies that the decisions/ directory should be excluded from the active memory count to ensure durable design decisions are not prematurely archived.

Comment thread commands/update.md
- Reconcile `llmdoc/memory/doc-gaps.md`: close resolved gaps, mark stale gaps, and add only actionable new gaps with closure criteria.

6. Run the active-memory archive check.
- After any new reflection is written, count active memory files under `llmdoc/memory/`, excluding `llmdoc/memory/lessons-learned.md`, `llmdoc/memory/doc-gaps.md`, and anything under `llmdoc/memory/archive/`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The archiving logic currently counts all files under llmdoc/memory/ (except for a few exclusions) to determine if the threshold of 5 is met. However, llmdoc/memory/decisions/ is intended for durable design or process decisions, which should typically not be archived. Including them in the count might trigger the archiving process prematurely or lead to durable decisions being moved to the archive. Consider explicitly excluding the decisions/ directory from the active memory count.

Suggested change
- After any new reflection is written, count active memory files under `llmdoc/memory/`, excluding `llmdoc/memory/lessons-learned.md`, `llmdoc/memory/doc-gaps.md`, and anything under `llmdoc/memory/archive/`.
- After any new reflection is written, count active memory files under llmdoc/memory/, excluding llmdoc/memory/lessons-learned.md, llmdoc/memory/doc-gaps.md, llmdoc/memory/decisions/, and anything under llmdoc/memory/archive/.

- Keep `llmdoc/memory/doc-gaps.md` reconciled by closing resolved gaps and adding only actionable new gaps.

6. Run the active-memory archive check.
- After any new reflection is written, count active memory files under `llmdoc/memory/`, excluding `llmdoc/memory/lessons-learned.md`, `llmdoc/memory/doc-gaps.md`, and anything under `llmdoc/memory/archive/`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The archiving logic currently counts all files under llmdoc/memory/ (except for a few exclusions) to determine if the threshold of 5 is met. However, llmdoc/memory/decisions/ is intended for durable design or process decisions, which should typically not be archived. Including them in the count might trigger the archiving process prematurely or lead to durable decisions being moved to the archive. Consider explicitly excluding the decisions/ directory from the active memory count.

Suggested change
- After any new reflection is written, count active memory files under `llmdoc/memory/`, excluding `llmdoc/memory/lessons-learned.md`, `llmdoc/memory/doc-gaps.md`, and anything under `llmdoc/memory/archive/`.
- After any new reflection is written, count active memory files under llmdoc/memory/, excluding llmdoc/memory/lessons-learned.md, llmdoc/memory/doc-gaps.md, llmdoc/memory/decisions/, and anything under llmdoc/memory/archive/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant