Repository navigation
WT grid scroll preview fixes - #1306
Merged
Merged
Conversation
Makes the behavior consistent with the game, when End frame is lower than the frame count: the End vel is effective at the actual end of the animation.
JoeyQuint
marked this pull request as ready for review
October 12, 2026 21:00
…back & monkey back) Crawl backwards, in TEN, has been changed to use a positive speed number. Also, TEN allows monkey swinging backwards, and also uses a positive speed number. In both cases, WT's grid scroll did not reflect that, it's now fixed (exploiting the hack that already existed for other states). (MONKEY_BACK has also been isolated to TEN only, in case other engines use that state number for another purpose in the future)
…states Core did not actually use velocities in their TR1-5 animations, but it's possible to use them to add some extra acceleration on top of what the engine already adds itself.
Collaborator
|
Looks good, but a patch note needs to be added to this PR if this is meant to be bundled with 2.0. |
Lwmte
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1305 by making the behavior consistent with the game, when End frame is lower than the frame count: the End vel is effective at the actual end of the animation.
Here is an example of the fix on the same problematic animation:
2026-10-12.23-03-31.mp4
The "bounce" is back.
Note that there is still a progressive shift from Lara's position away from the origin, this is most likely the same issue as mentioned #1307
Also adds a few forgotten TEN states to the hack that makes the grid scroll in the "correct" direction (when the engine forces a different direction for specific states).