replace stringstream zmq parsing with string construction so we don't rely on null terminated messages#56
Open
marc1uk wants to merge 1 commit into
Open
replace stringstream zmq parsing with string construction so we don't rely on null terminated messages#56marc1uk wants to merge 1 commit into
marc1uk wants to merge 1 commit into
Conversation
… rely on null terminated messages
Contributor
Author
|
Just commenting here so as not to forget: this breaks RemoteControl (and potentially other things). but it would be good to do this in one step if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::stringstream expects its input to be null terminated.
Unless we guarantee that all zmq messages received are null terminated, this could lead to the stringstream reading past the end of the message and into arbitrary data, risking segfaulting.
This replaces all instances i could find of std::stringstream for zmq message parsing with a std::string construction that takes the message size. A stringstream is subsequently constructed from this string in the couple of instances where the streamer extraction operator is used.