fix(core): update contract error resolution signatures and add error …#279
Open
Bilalishaq7 wants to merge 1 commit into
Open
fix(core): update contract error resolution signatures and add error …#279Bilalishaq7 wants to merge 1 commit into
Bilalishaq7 wants to merge 1 commit into
Conversation
…documentation links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #263
Overview
I'm all done with this implementation! This PR introduces the missing
learn_moreerror documentation links to our diagnostic reports and resolves the compilation issues that cropped up from the recent context updates.What's Done
DiagnosticReportstruct generation logic insidereport.rs.crates/core/src/decode/mod.rsto map correctly todecode_context.rsinstead of the legacycontext.rsname.DecodeContextfrom the network configurations and pass its reference cleanly intocontract_error::resolve.enrich_report.Verification
cargo testand everything builds and passes cleanly without diagnostics errors.Closes #263