OPENGL: Terrain doesnt render correctly#1711
Merged
Azaezel merged 5 commits intoTorqueGameEngines:developmentfrom Apr 11, 2026
Merged
OPENGL: Terrain doesnt render correctly#1711Azaezel merged 5 commits intoTorqueGameEngines:developmentfrom
Azaezel merged 5 commits intoTorqueGameEngines:developmentfrom
Conversation
The core of this issue was the unlock on the GFXGLTextureObject Few other bug fixes around setting a texture binding to 0, notice in clear function we now also clear the glprogram and the buffers. This seems to fix most of the warnings around id 131204 This warning was triggered every frame, now it just triggers when a shader expects a texture but none is active.
marauder2k7
changed the title
clearing the active program caused issues during a target bake as we call glClear after setting the shader etc. As this warning id 131204 seems to be a product of doing this, everything i read up on it says it is safe to silence it.
update bitmapPng reading from libpng to have context in warnings and errors, also add a bit of a better structure around the read and write functions. Interlaced PNG's were never being accounted for before so add the png_set_interlace_handling for interlaced pngs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core of this issue was the unlock on the GFXGLTextureObject
Few other bug fixes around setting a texture binding to 0, notice in clear function we now also clear the glprogram and the buffers. This seems to fix most of the warnings around id 131204
This warning was triggered every frame, now it just triggers when a shader expects a texture but none is active.