Skip to content

Fix autoRetire when the lowest scored tco2 is not present in the pool #31 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danceratopz wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix autoRetire when the lowest scored tco2 is not present in the pool #31 #32

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00b7d33
tests: add a test case for #31
danceratopz Aug 9, 2022
f0489cf
fix: don't call retire if the tco2 amount is zero #31
danceratopz Aug 9, 2022
d37cbd0
chore: enable github actions for pushes and prs on all branches
danceratopz Aug 9, 2022
eb19d3a
fix: increment counter in while loop, forgotten in f0489cfb
danceratopz Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contracts/OffsetHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,9 @@ contract OffsetHelper is OffsetHelperStorage {
balances[msg.sender][_tco2s[i]] >= _amounts[i],
"Insufficient TCO2 balance"
);

if (_amounts[i] == 0) {
Comment thread
mauricedesaxe marked this conversation as resolved.
Outdated
continue;
}
balances[msg.sender][_tco2s[i]] -= _amounts[i];

IToucanCarbonOffsets(_tco2s[i]).retire(_amounts[i]);
Expand Down