Compatible with RealCamera#556
Draft
H31M5 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compatibility issues with RealCamera, as shown in the attached screenshot
P.S. The screenshot was captured to reproduce the bug on an older version. No resource pack that triggers the issue has been found in the latest release yet, so the fix cannot be verified for the time being
I inject via Mixin into the computeCamera() and captureRotatedEntity(), adding a static boolean flag to toggle single-frame guard activation
Also, I'm unsure whether I should use @pseudo or shouldApplyMixin here, so I kept both annotations.
I also don't know the standard, more idiomatic way to write multi-version compatible mods, so this is the implementation I came up with.