Adding adapter tests for Qwen2#1309
Open
Rishik00 wants to merge 6 commits into
Open
Conversation
* Fix type of HookedTransformerConfig.device This is typed as `Optional[str]` but sometimes returns `torch.device`. Updated the code to just return the `str` instead of wrapping with a device. I'm not confident that every function which takes a device will always be passed a string, so I didn't change functions like warn_if_mps. Found while working on TransformerLensOrg#1219 * more cleanup * 3.0 CI Bugs (TransformerLensOrg#1261) * Fixing `utils` imports * skip gated notebooks on PR from forks * Updating notebooks * Ensure LLaMA only runs when HF_TOKEN is available --------- Co-authored-by: jlarson4 <jonahalarson@comcast.net>
TransformerLens 3.1.0
jlarson4
reviewed
May 18, 2026
Collaborator
jlarson4
left a comment
jlarson4
left a comment
There was a problem hiding this comment.
Hi @Rishik00! This is an excellent test suite, I left one comment on the code and have one additional ask:
Can we get some testing for Qwen2's setup_component_testing override? That is the biggest feature that currently isn't getting tested. If you'd like a reference, another contributor has a great example of roughly what I'm looking for in #1311
| return Qwen2ArchitectureAdapter(cfg) | ||
|
|
||
|
|
||
| class FakeQwen2Attention(nn.Module): |
Collaborator
There was a problem hiding this comment.
This is excellent, and it would be great to write some tests that use it, but at present it does not appear wired into anything?
Author
There was a problem hiding this comment.
My apologies. Will wire it up and update the PR!
Author
|
Of course! I will get that added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit coverage for the Qwen2 architecture adapter.
Changes
To run the test: uv run pytest tests\unit\model_bridge\supported_architectures\test_qwen2_adapter.py
Relevant to Issue #1302 @jlarson4